Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ☂️ Login issues with root path and SSO #5362

Open
1 of 7 tasks
stdweird opened this issue Nov 14, 2024 · 0 comments
Open
1 of 7 tasks

[BUG] ☂️ Login issues with root path and SSO #5362

stdweird opened this issue Nov 14, 2024 · 0 comments
Assignees
Labels
bug Something isn't working c/auth priority: high

Comments

@stdweird
Copy link

stdweird commented Nov 14, 2024

Describe the bug
Trying a setup with phoenix 5.8.0 from container.
Configuration has PHOENIX_HOST_ROOT_PATH=/test set, authentication and SSO is configured to be used and the whole setup is behind a proxy (https://my.host/test redirects to the container).

3 things go wrong:

  1. navigating to https://my.host/test ends up trying to access https://my.host/login?returnUrl=%2Ftest; which can't work. manually adding the root path https://my.host/test/login?returnUrl=%2Ftest does bring me to the login page. the root path does work (i see in the logs that urls are being fetched; i presume some fallback code in case of unauthenticated access is missing the root path). the SSO login button has same issue: it tries to go to https://my.host/oauth2/... instead of https://my.host/test/oauth2/.... (Also the "return home" button in case of failure with SSO does not use the root path, it goes back to https://my.host instead of https://my.host/test)
  2. i cannot use the admin@localhost / admin credentials to login using the username/password. is that due to the SSO setup? not really clear form the docs if this should always work or not. i have not tried a setup without the SSO bits.
  3. the login screen has no scrollbar, see screenshot. i need to zoom out to see the SSO button. also, with SSO enabled, it might make more sense to put the SSO login first, and the username/password as second option (or have separate url for username/password login; this will only confuse people imho).
    phoenix_login_screen

To Reproduce

Expected behavior
Fallback to working login page in case first access to the site. Being able to login with admin credentials, aside from any SSO authentication.

Screenshots
Is attached for the missing scrollbar issue

Environment (please complete the following information):
Tested on fedora, with firefox browser.

Additional context

@stdweird stdweird added bug Something isn't working triage issues that need triage labels Nov 14, 2024
@github-project-automation github-project-automation bot moved this to 📘 Todo in phoenix Nov 14, 2024
@dosubot dosubot bot added the c/server Server implementation label Nov 14, 2024
@axiomofjoy axiomofjoy added c/auth and removed c/server Server implementation triage issues that need triage labels Nov 14, 2024
@axiomofjoy axiomofjoy self-assigned this Nov 14, 2024
@axiomofjoy axiomofjoy moved this from 📘 Todo to 👨‍💻 In progress in phoenix Nov 14, 2024
@axiomofjoy axiomofjoy changed the title [BUG] Login issues with root path and SSO [BUG] ☂️ Login issues with root path and SSO Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c/auth priority: high
Projects
Status: 👨‍💻 In progress
Development

No branches or pull requests

3 participants