Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent directory is being re-read when returning from subdir #12

Open
bubbob42 opened this issue Nov 1, 2023 · 2 comments
Open

Parent directory is being re-read when returning from subdir #12

bubbob42 opened this issue Nov 1, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@bubbob42
Copy link

bubbob42 commented Nov 1, 2023

If you dive into a subdirectory and return to the root dir via back-button, the whole volume will be scanned again. Maybe (optionally) cache the results to speed things up? :-)

@Arisamiga Arisamiga added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Nov 1, 2023
@Arisamiga
Copy link
Owner

Arisamiga commented Nov 1, 2023

If you dive into a subdirectory and return to the root dir via back-button, the whole volume will be scanned again. Maybe (optionally) cache the results to speed things up? :-)

Hello, Thanks for creating an issue :D

Mnemosyne doesn't cache it because of the idea that something in the root directory may have changed (Files might have been deleted, files might have changed size or new files might have been created, etc.) and to cache would also either require either using more memory or writing on a file which can take more hard drive space which is something I don't wanna cause issues with.

@bubbob42
Copy link
Author

bubbob42 commented Nov 2, 2023

Hi!

Entering a subdir and returning to root can cause very long delays (half an hour on big partition with lots of files) due to rescan.

I'd suggest keeping the root directory in memory and use dos.library's StartNotify()/EndNotify() to watch for changes. Trigger a rescan only when changes did occur in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants