Mavgen JS: Set encoding when opening generated files #1127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to use mavgen.py with "JavaScript_NextGen" language, on Windows I was getting the following error:
It seems that on Windows the opened output file encoding defaults to cp1252 encoding, but mavgen is attempting to output some JS functions containing UTF8 characters, such as this one:
The fix is to force the encoding of the output JS files to be UTF8.
Checked and seems to work in my local Windows environment, generating valid JS files.