feat(flightcontroller): Make MAVFTP more robust on F4 processors

Author: amilcarlucas

ardupilot_methodic_configurator/backend_flightcontroller.py

@@ -31,7 +31,7 @@
 from ardupilot_methodic_configurator import _
 from ardupilot_methodic_configurator.argparse_check_range import CheckRange
 from ardupilot_methodic_configurator.backend_flightcontroller_info import BackendFlightcontrollerInfo
-from ardupilot_methodic_configurator.backend_mavftp import MAVFTP
+from ardupilot_methodic_configurator.backend_mavftp import MAVFTP, MAVFTPSettings
 from ardupilot_methodic_configurator.data_model_par_dict import ParDict
 
 # pylint: disable=too-many-lines
@@ -653,7 +653,30 @@ def _download_params_via_mavlink(
                 break
         return parameters
 
-    def _download_params_via_mavftp(
+    def _create_robust_mavftp_settings(self) -> MAVFTPSettings:
+        """
+        Create robust MAVFTP settings optimized for STM32 F4 controllers under workload.
+
+        Returns:
+            MAVFTPSettings: Configured settings with increased timeouts and reduced burst sizes
+
+        """
+        return MAVFTPSettings(
+            [
+                ("debug", int, 0),
+                ("pkt_loss_tx", int, 0),
+                ("pkt_loss_rx", int, 0),
+                ("max_backlog", int, 3),  # Reduced backlog for better reliability
+                ("burst_read_size", int, 60),  # Smaller burst size for stability
+                ("write_size", int, 60),
+                ("write_qsize", int, 3),
+                ("idle_detection_time", float, 3.7),
+                ("read_retry_time", float, 3.0),  # Increased retry time
+                ("retry_time", float, 2.0),  # Increased retry time
+            ]
+        )
+
+    def _download_params_via_mavftp(  # pylint: disable=too-many-locals
         self,
         progress_callback: Union[None, Callable[[int, int], None]] = None,
         parameter_values_filename: Optional[Path] = None,
@@ -676,21 +699,60 @@ def _download_params_via_mavftp(
         """
         if self.master is None:
             return {}, ParDict()
-        mavftp = MAVFTP(self.master, target_system=self.master.target_system, target_component=self.master.target_component)
+
+        # Create more robust MAVFTP settings for parameter download
+        # STM32 F4 controllers under workload need longer timeouts
+        mavftp_settings = self._create_robust_mavftp_settings()
+
+        mavftp = MAVFTP(
+            self.master,
+            target_system=self.master.target_system,
+            target_component=self.master.target_component,
+            settings=mavftp_settings,
+        )
 
         def get_params_progress_callback(completion: float) -> None:
             if progress_callback is not None and completion is not None:
                 progress_callback(int(completion * 100), 100)
 
         complete_param_filename = str(parameter_values_filename) if parameter_values_filename else "complete.param"
         default_param_filename = str(parameter_defaults_filename) if parameter_defaults_filename else "00_default.param"
-        mavftp.cmd_getparams([complete_param_filename, default_param_filename], progress_callback=get_params_progress_callback)
-        ret = mavftp.process_ftp_reply("getparams", timeout=40)  #  on slow links it might take a long time
-        pdict: dict[str, float] = {}
-        defdict: ParDict = ParDict()
+
+        # Retry logic for increased robustness with STM32 F4 controllers under workload
+        max_retries = 3
+        base_timeout = 15
+
+        for attempt in range(max_retries):
+            try:
+                mavftp.cmd_getparams(
+                    [complete_param_filename, default_param_filename], progress_callback=get_params_progress_callback
+                )
+                # Progressive timeout increase for each retry attempt
+                timeout = base_timeout * (2**attempt)  # 15s, 30s, 60s
+                logging_info(_("Attempt %d/%d: Requesting parameters with %ds timeout"), attempt + 1, max_retries, timeout)
+                ret = mavftp.process_ftp_reply("getparams", timeout=timeout)
+
+                if ret.error_code == 0:
+                    break  # Success, exit retry loop
+
+                if attempt < max_retries - 1:  # Don't sleep after last attempt
+                    sleep_time = 2**attempt  # 1s, 2s, 4s exponential backoff
+                    logging_warning(_("Parameter download attempt %d failed, retrying in %ds..."), attempt + 1, sleep_time)
+                    time_sleep(sleep_time)
+                else:
+                    logging_error(_("All %d parameter download attempts failed"), max_retries)
+
+            except Exception as e:  # pylint: disable=broad-exception-caught
+                logging_error(_("Exception during parameter download attempt %d: %s"), attempt + 1, str(e))
+                if attempt < max_retries - 1:
+                    sleep_time = 2**attempt
+                    time_sleep(sleep_time)
 
         # add a file sync operation to ensure the file is completely written
         time_sleep(0.3)
+
+        pdict: dict[str, float] = {}
+        defdict: ParDict = ParDict()
         if ret.error_code == 0:
             # load the parameters from the file
             par_dict = ParDict.from_file(complete_param_filename)
@@ -1152,14 +1214,23 @@ def upload_file(
         """Upload a file to the flight controller."""
         if self.master is None:
             return False
-        mavftp = MAVFTP(self.master, target_system=self.master.target_system, target_component=self.master.target_component)
+
+        # Use robust MAVFTP settings for better reliability with STM32 F4 controllers
+        mavftp_settings = self._create_robust_mavftp_settings()
+        mavftp = MAVFTP(
+            self.master,
+            target_system=self.master.target_system,
+            target_component=self.master.target_component,
+            settings=mavftp_settings,
+        )
 
         def put_progress_callback(completion: float) -> None:
             if progress_callback is not None and completion is not None:
                 progress_callback(int(completion * 100), 100)
 
         mavftp.cmd_put([local_filename, remote_filename], progress_callback=put_progress_callback)
-        ret = mavftp.process_ftp_reply("CreateFile", timeout=10)
+        # Increased timeout for better reliability
+        ret = mavftp.process_ftp_reply("CreateFile", timeout=20)
         if ret.error_code != 0:
             ret.display_message()
         return ret.error_code == 0
@@ -1177,7 +1248,14 @@ def download_last_flight_log(
             logging_error(error_msg)
             return False
 
-        mavftp = MAVFTP(self.master, target_system=self.master.target_system, target_component=self.master.target_component)
+        # Use robust MAVFTP settings for better reliability with STM32 F4 controllers
+        mavftp_settings = self._create_robust_mavftp_settings()
+        mavftp = MAVFTP(
+            self.master,
+            target_system=self.master.target_system,
+            target_component=self.master.target_component,
+            settings=mavftp_settings,
+        )
 
         def get_progress_callback(completion: float) -> None:
             if progress_callback is not None and completion is not None:

ardupilot_methodic_configurator/backend_mavftp.py

@@ -377,7 +377,8 @@ def __init__(
 
         # Reset the flight controller FTP state-machine
         self.__send(FTP_OP(self.seq, self.session, OP_ResetSessions, 0, 0, 0, 0, None))
-        self.process_ftp_reply("ResetSessions")
+        # Increased timeout for ResetSessions to be more robust on loaded STM32 F4 controllers
+        self.process_ftp_reply("ResetSessions", timeout=10)
 
     def cmd_ftp(self, args) -> MAVFTPReturn:  # noqa PRL0911, pylint: disable=too-many-return-statements, too-many-branches
         """FTP operations."""