-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gedit, gnome-terminal and others crash in rootless mode #82
Comments
Hi Camilo, On Do 02 Jul 2015 08:21:22 CEST, Camilo Alejandro Arboleda wrote: Your bug report has just been moved [1] to the new upstream location of nx-libs on Github.
Is it really a malformed request or a problem with broken BIG-REQUESTS support [2] in libXcomp3 (aka nxcomp)?
Is option 3. really the optimal approach? It feels like option 2. would be the way to go here... Please continue, if possible for you, this discussion on Github. Mike |
Also related: X2Go Bug 878: Package: nx-libs Server OS: Fedora 22 64-bit with latest updates (F22 is still in beta, I've tried multiple different clients (on both Linux and Windows), so The problem is that gnome-terminal is failing to launch. I have only This line stands out: However, XEvIE was removed from X.org in 2008: |
Hi Mike, I haven't look deeper into the problem, since I am not really expert (or even knowledgeable) in X. The first patch was a quick fix as it seemed to me that NXlib doesn't support big requests, and it has worked for me so far. I am sorry to not being able to help to come up with a better solution, but I don't have the knowledge to do it. I can help with testing and debugging if you have any pointers I can follow. |
Ubuntu 16.04.1 and stable ppa are affected by the same bug. Application: rootless Eclipse Kepler. On Ubuntu 14.04 everything works fine with the same versions of x2go from stable ppa.
ubuntu 16.04 (bug)
ubuntu 14.04 (no bug)
|
I'm suffering from the same bug on Ubuntu 16.04 while it previously worked in 14.04. |
On Sat, Sep 10, 2016 at 1:03 PM, Colin Finck notifications@github.com wrote:
Have you tried using the latest nightly builds of nx-libs? Uli |
Hi Uli, hi Colin, On So 11 Sep 2016 12:19:27 CEST, Ulrich Sibiller wrote:
Unfortunately, BIG-REQUESTS are broken-by-design in nxcomp. See: Do thinks work better when disabling BIG-REQUESTS in x2goagent/nxagent? From the command line (although, this does not use nxcomp): nxagent -R -ac -extension BIG-REQUESTS :1 Or via /etc/x2go/x2goagent.options. Mike DAS-NETZWERKTEAM GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 |
Yep, adding "-extension BIG-REQUESTS" to the X2GO_NXAGENT_DEFAULT_OPTIONS variable in /etc/x2go/x2goagent.options fixes the problem as well! |
This is a multi-topic bug. Basically, GNOME applications run (again) on nx-libs 3.5.99.3 and above. This has been tested with gedit and gnome-terminal from Debian jessie and Debian stretch. So that issues seems to be settled. Evolution (not sure if it was mentioned above, but it also is a problematic application) fails to launch on jessie due to missing recent-enough GLX support. The stretch version of evolution comes up, but reports thrillions of issues about permission denied to some shared memory location. However, that may also be related to my test setup (schroot based chroots). The BIGREQUESTS stuff is tracked by another issue on this tracker: #301. Regarding Eclipse, the eclipse version from Debian stretch starts fine in rootless and desktop session mode. So really closing this issue now. |
From X2Go BTS (with patch there):
http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=900
Package: libnx-X11
Version: 2.3.5
Setup:
Results:
A quick look in dmesg shows that libNX_X11.so.6.2 caused a SEGFAULT.
Running x2goagent with a debugger gives the following backtrace:
(gdb) backtrace
#0 _XData32 (dpy=dpy@entry=0xf591b0, data=data@entry=0x163c2c4,
len=len@entry=18652) at XlibInt.c:3775
#1 0x00007f759e34dce1 in XChangeProperty (dpy=0xf591b0, w=<optimized
out>, property=, type=6, format=,
mode=,
data=0x163c2c4
"\377\377\377\377\354\356\356\377\377\377\377\377\354\356\356\377\377\377\377\377\354\356\356\377\377\377\377\377\357\360\360\377\377\377\377\377\364\365\365\377\377\377\377\377\307\312\311\375\377\377\377\377\t\t\t\035",
nelements=4663) at ChProp.c:85
#2 0x00000000004b1e37 in nxagentExportProperty (pWin=0x20,
property=4663, type=23315140, format=4669, mode=32, nUnits=4663,
value=0x15fc2e0) at Rootless.c:763
#3 0x000000000042222a in ProcChangeProperty (client=0xf591b0) at
X/NXproperty.c:331
#4 0x000000000042eea2 in Dispatch () at X/NXdispatch.c:748
Looking at the highlighted values, it seems that gedit is sending a
malformed ChangeProperty request, and rootless is failing to process it.
Specifically the segment between lines 735-780, tries to set a property
that is bigger than the maximum size required, but because it's a
malformed request it ends up writing in memory outside the boundaries of
the output buffer.
Alternatives:
of the output buffer.
(ProcChangeProperty seems to do something similar).
The text was updated successfully, but these errors were encountered: