Skip to content

Conversation

@black-sliver
Copy link
Member

What is this fixing or adding?

Remove deprecated use of Utils.get_options() from SoE World.
The call to user_path(), or get_base_rom_path() in general, is not really required anymore with the settings API, but I tried to make the change as minimal as possible.

Resolves SoE for #4811

How was this tested?

  • Generated with .sfc missing -> Cancel -> Gen stops with readable error
  • Generated with .sfc missing -> Selected sfc -> Gen succeeds
  • Generated with .sfc existing -> Gen succeeds
  • Launcher -> Open Patch with .sfc missing -> Cancel -> Launching stops with readable error in MsgBox
  • Launcher -> Open Patch with .sfc missing -> Selected sfc -> Patching + launching succeeds
  • Launcher -> Open Patch with .sfc existing -> Patching + launching succeeds

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Apr 6, 2025
@black-sliver black-sliver merged commit 8c79499 into ArchipelagoMW:main Apr 6, 2025
16 checks passed
@black-sliver black-sliver deleted the soe/fix/options-deprecation branch April 6, 2025 15:00
ProfDeCube pushed a commit to ProfDeCube/Archipelago that referenced this pull request Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants