-
-
Notifications
You must be signed in to change notification settings - Fork 86
chore: Rework starting scripts for Windows #738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Congrats Ales on your first PR! Is there any chance you can also fix the banner? For some reason doesn't work with .bat. This is on server.sh: |
mergify bot
added a commit
that referenced
this pull request
Sep 14, 2025
…6.0 to 3.6.1 [skip ci] Bumps [org.apache.maven.plugins:maven-shade-plugin](https://github.com/apache/maven-shade-plugin) from 3.6.0 to 3.6.1. Release notes *Sourced from [org.apache.maven.plugins:maven-shade-plugin's releases](https://github.com/apache/maven-shade-plugin/releases).* > 3.6.1 > ----- > > 📝 Documentation updates > ----------------------- > > * [[MNGSITE-529]](https://issues.apache.org/jira/browse/MNGSITE-529) - Rename "Goals" to "Plugin Documentation" ([#250](https://redirect.github.com/apache/maven-shade-plugin/pull/250)) [`@Bukama`](https://github.com/Bukama) > > 👻 Maintenance > ------------- > > * Enable prevent branch protection rules ([#746](https://redirect.github.com/apache/maven-shade-plugin/pull/746)) [`@sparsick`](https://github.com/sparsick) > * Enable GH issues ([#253](https://redirect.github.com/apache/maven-shade-plugin/pull/253)) [`@Bukama`](https://github.com/Bukama) > * Add missing [`@Override`](https://github.com/Override) annotations ([#246](https://redirect.github.com/apache/maven-shade-plugin/pull/246)) [`@elharo`](https://github.com/elharo) > * Merge `ApacheLicenseResourceTransformer` tests ([#245](https://redirect.github.com/apache/maven-shade-plugin/pull/245)) [`@Goooler`](https://github.com/Goooler) > * Add test cases for .md supports in the Apache License and Notice transformers ([#243](https://redirect.github.com/apache/maven-shade-plugin/pull/243)) [`@Goooler`](https://github.com/Goooler) > * [[MSHADE-479]](https://issues.apache.org/jira/browse/MSHADE-479) - Make the mojo much less noisy ([#233](https://redirect.github.com/apache/maven-shade-plugin/pull/233)) [`@elharo`](https://github.com/elharo) > > 📦 Dependency updates > -------------------- > > * Bump org.codehaus.mojo:mrm-maven-plugin from 1.6.0 to 1.7.0 ([#748](https://redirect.github.com/apache/maven-shade-plugin/pull/748)) @[dependabot[bot]](https://github.com/apps/dependabot) > * Bump org.hamcrest:hamcrest-core from 2.2 to 3.0 ([#235](https://redirect.github.com/apache/maven-shade-plugin/pull/235)) @[dependabot[bot]](https://github.com/apps/dependabot) > * Bump org.apache.maven.plugins:maven-plugins from 42 to 45 ([#738](https://redirect.github.com/apache/maven-shade-plugin/pull/738)) @[dependabot[bot]](https://github.com/apps/dependabot) > * Bump org.apache.commons:commons-compress from 1.26.2 to 1.28.0 ([#743](https://redirect.github.com/apache/maven-shade-plugin/pull/743)) @[dependabot[bot]](https://github.com/apps/dependabot) > * Bump org.xmlunit:xmlunit-legacy from 2.10.0 to 2.10.3 ([#745](https://redirect.github.com/apache/maven-shade-plugin/pull/745)) @[dependabot[bot]](https://github.com/apps/dependabot) > * Bump ASM 9.8 to support JDK 25 bytecode ([#744](https://redirect.github.com/apache/maven-shade-plugin/pull/744)) [`@pan3793`](https://github.com/pan3793) > * Bump commons-io:commons-io from 2.13.0 to 2.14.0 in /src/it/projects/MSHADE-105/shaded-jar ([#241](https://redirect.github.com/apache/maven-shade-plugin/pull/241)) @[dependabot[bot]](https://github.com/apps/dependabot) Commits * [`9662c98`](apache/maven-shade-plugin@9662c98) [maven-release-plugin] prepare for next development iteration * [`06902bd`](apache/maven-shade-plugin@06902bd) [maven-release-plugin] prepare release maven-shade-plugin-3.6.1 * [`29e9a9d`](apache/maven-shade-plugin@29e9a9d) add .git * [`844e61a`](apache/maven-shade-plugin@844e61a) use github * [`43101f9`](apache/maven-shade-plugin@43101f9) [maven-release-plugin] prepare release maven-shade-plugin-3.6.1 * [`2ffb28d`](apache/maven-shade-plugin@2ffb28d) use release drafter v4 and dependabot to updade gha as well ([#750](https://redirect.github.com/apache/maven-shade-plugin/issues/750)) * [`f5b590e`](apache/maven-shade-plugin@f5b590e) Bump org.codehaus.mojo:mrm-maven-plugin from 1.6.0 to 1.7.0 * [`eee0319`](apache/maven-shade-plugin@eee0319) Bump org.hamcrest:hamcrest-core from 2.2 to 3.0 * [`0d5a7a4`](apache/maven-shade-plugin@0d5a7a4) fix upgrade, remove those useless final * [`6e5f0f3`](apache/maven-shade-plugin@6e5f0f3) Bump org.apache.maven.plugins:maven-plugins from 42 to 45 * Additional commits viewable in [compare view](apache/maven-shade-plugin@maven-shade-plugin-3.6.0...v3.6.1) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR improves following:
server.bat,console.batand evenstresstester.batconsole.batorserver.batare launched from a different current directorymvn.cmdbut only a little bitMotivation
Improve experience for Windows developers.
I'm able to create a manifest for Scoop installer and make ArcadeDB installable using simple
scoop install arcadedbonce we have launch scripts in a good shape.Additional Notes
My appologies I actually touched license blocks. There was one duplicate in
console.batand conflicting copyright onstresstester.bat. I expect request for change with suggestion during review.Also I was unable to test
stresstester.batas I'm missing some classes.I changed arcadedb.com to https://arcadedb.com intentionally on console output reason being terminals actually can make this link clickable.
Demo
Launch server
Launch console
Checklist
mvn clean packagecommand