Skip to content

Conversation

@littleli
Copy link
Contributor

@littleli littleli commented Jan 3, 2023

What does this PR do?

This PR improves following:

  • covers server.bat, console.bat and even stresstester.bat
  • fixes syntactic issues in batch files for Windows when lookup up for java executable
  • now it searches for java executable on PATH
  • prints actual resolved ARCADEDB_HOME and script path to output at launch
  • always changes directory to ARCADEDB_HOME so database files, logs and config directories are used correctly even if console.bat or server.bat are launched from a different current directory
  • Inspiration was taken partially from Maven's mvn.cmd but only a little bit

Motivation

Improve experience for Windows developers.
I'm able to create a manifest for Scoop installer and make ArcadeDB installable using simple scoop install arcadedb once we have launch scripts in a good shape.

Additional Notes

My appologies I actually touched license blocks. There was one duplicate in console.bat and conflicting copyright on stresstester.bat. I expect request for change with suggestion during review.

Also I was unable to test stresstester.bat as I'm missing some classes.

I changed arcadedb.com to https://arcadedb.com intentionally on console output reason being terminals actually can make this link clickable.

Demo

Launch server

arcadedb-server

Launch console

arcadedb-console

Checklist

  • [N/A] I have run the build using mvn clean package command
  • [N/A] My unit tests cover both failure and success scenarios

@lvca lvca added bug Something isn't working fixed / implemented labels Jan 4, 2023
@lvca lvca added this to the 23.1.1 milestone Jan 4, 2023
@lvca lvca merged commit 7f28711 into ArcadeData:main Jan 4, 2023
@lvca
Copy link
Contributor

lvca commented Jan 4, 2023

Congrats Ales on your first PR!

Is there any chance you can also fix the banner? For some reason doesn't work with .bat. This is on server.sh:

echo ""
echo " █████╗ ██████╗  ██████╗ █████╗ ██████╗ ███████╗██████╗ ██████╗"
echo "██╔══██╗██╔══██╗██╔════╝██╔══██╗██╔══██╗██╔════╝██╔══██╗██╔══██╗"
echo "███████║██████╔╝██║     ███████║██║  ██║█████╗  ██║  ██║██████╔╝"
echo "██╔══██║██╔══██╗██║     ██╔══██║██║  ██║██╔══╝  ██║  ██║██╔══██╗"
echo "██║  ██║██║  ██║╚██████╗██║  ██║██████╔╝███████╗██████╔╝██████╔╝"
echo "╚═╝  ╚═╝╚═╝  ╚═╝ ╚═════╝╚═╝  ╚═╝╚═════╝ ╚══════╝╚═════╝ ╚═════╝"
echo "PLAY WITH DATA                                    arcadedb.com"

mergify bot added a commit that referenced this pull request Sep 14, 2025
…6.0 to 3.6.1 [skip ci]

Bumps [org.apache.maven.plugins:maven-shade-plugin](https://github.com/apache/maven-shade-plugin) from 3.6.0 to 3.6.1.
Release notes

*Sourced from [org.apache.maven.plugins:maven-shade-plugin's releases](https://github.com/apache/maven-shade-plugin/releases).*

> 3.6.1
> -----
>
> 📝 Documentation updates
> -----------------------
>
> * [[MNGSITE-529]](https://issues.apache.org/jira/browse/MNGSITE-529) - Rename "Goals" to "Plugin Documentation" ([#250](https://redirect.github.com/apache/maven-shade-plugin/pull/250)) [`@​Bukama`](https://github.com/Bukama)
>
> 👻 Maintenance
> -------------
>
> * Enable prevent branch protection rules ([#746](https://redirect.github.com/apache/maven-shade-plugin/pull/746)) [`@​sparsick`](https://github.com/sparsick)
> * Enable GH issues ([#253](https://redirect.github.com/apache/maven-shade-plugin/pull/253)) [`@​Bukama`](https://github.com/Bukama)
> * Add missing [`@​Override`](https://github.com/Override) annotations ([#246](https://redirect.github.com/apache/maven-shade-plugin/pull/246)) [`@​elharo`](https://github.com/elharo)
> * Merge `ApacheLicenseResourceTransformer` tests ([#245](https://redirect.github.com/apache/maven-shade-plugin/pull/245)) [`@​Goooler`](https://github.com/Goooler)
> * Add test cases for .md supports in the Apache License and Notice transformers ([#243](https://redirect.github.com/apache/maven-shade-plugin/pull/243)) [`@​Goooler`](https://github.com/Goooler)
> * [[MSHADE-479]](https://issues.apache.org/jira/browse/MSHADE-479) - Make the mojo much less noisy ([#233](https://redirect.github.com/apache/maven-shade-plugin/pull/233)) [`@​elharo`](https://github.com/elharo)
>
> 📦 Dependency updates
> --------------------
>
> * Bump org.codehaus.mojo:mrm-maven-plugin from 1.6.0 to 1.7.0 ([#748](https://redirect.github.com/apache/maven-shade-plugin/pull/748)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * Bump org.hamcrest:hamcrest-core from 2.2 to 3.0 ([#235](https://redirect.github.com/apache/maven-shade-plugin/pull/235)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * Bump org.apache.maven.plugins:maven-plugins from 42 to 45 ([#738](https://redirect.github.com/apache/maven-shade-plugin/pull/738)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * Bump org.apache.commons:commons-compress from 1.26.2 to 1.28.0 ([#743](https://redirect.github.com/apache/maven-shade-plugin/pull/743)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * Bump org.xmlunit:xmlunit-legacy from 2.10.0 to 2.10.3 ([#745](https://redirect.github.com/apache/maven-shade-plugin/pull/745)) @[dependabot[bot]](https://github.com/apps/dependabot)
> * Bump ASM 9.8 to support JDK 25 bytecode ([#744](https://redirect.github.com/apache/maven-shade-plugin/pull/744)) [`@​pan3793`](https://github.com/pan3793)
> * Bump commons-io:commons-io from 2.13.0 to 2.14.0 in /src/it/projects/MSHADE-105/shaded-jar ([#241](https://redirect.github.com/apache/maven-shade-plugin/pull/241)) @[dependabot[bot]](https://github.com/apps/dependabot)


Commits

* [`9662c98`](apache/maven-shade-plugin@9662c98) [maven-release-plugin] prepare for next development iteration
* [`06902bd`](apache/maven-shade-plugin@06902bd) [maven-release-plugin] prepare release maven-shade-plugin-3.6.1
* [`29e9a9d`](apache/maven-shade-plugin@29e9a9d) add .git
* [`844e61a`](apache/maven-shade-plugin@844e61a) use github
* [`43101f9`](apache/maven-shade-plugin@43101f9) [maven-release-plugin] prepare release maven-shade-plugin-3.6.1
* [`2ffb28d`](apache/maven-shade-plugin@2ffb28d) use release drafter v4 and dependabot to updade gha as well ([#750](https://redirect.github.com/apache/maven-shade-plugin/issues/750))
* [`f5b590e`](apache/maven-shade-plugin@f5b590e) Bump org.codehaus.mojo:mrm-maven-plugin from 1.6.0 to 1.7.0
* [`eee0319`](apache/maven-shade-plugin@eee0319) Bump org.hamcrest:hamcrest-core from 2.2 to 3.0
* [`0d5a7a4`](apache/maven-shade-plugin@0d5a7a4) fix upgrade, remove those useless final
* [`6e5f0f3`](apache/maven-shade-plugin@6e5f0f3) Bump org.apache.maven.plugins:maven-plugins from 42 to 45
* Additional commits viewable in [compare view](apache/maven-shade-plugin@maven-shade-plugin-3.6.0...v3.6.1)
  
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=org.apache.maven.plugins:maven-shade-plugin&package-manager=maven&previous-version=3.6.0&new-version=3.6.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working fixed / implemented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants