Cypher : fix param in match

[ExtReMLapin]

fixes #3476

[WARNING] Tests run: 980, Failures: 0, Errors: 0, Skipped: 6

Claude wrote the fix and got lost in a compilation loop bug, checked the fix, it works

Checklist

• I have run the build using mvn clean package command
• My unit tests cover both failure and success scenarios

[gemini-code-assist]

Summary of Changes

Hello @ExtReMLapin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical bug in Cypher query execution where parameters used within inline node-pattern property filters in MATCH clauses were not being correctly resolved. The fix ensures that ParameterReference objects are properly evaluated against the input parameters, allowing queries like MATCH (n:LABEL {prop: $param}) to function as expected and return accurate results.

Highlights

• Cypher Parameter Resolution Fix: Implemented logic in MatchNodeStep.java to correctly resolve ParameterReference objects when used in MATCH clause property filters, addressing a bug where such queries would return no results.
• New Regression Test: Added inlineNodePatternParameterMatching test case to ParameterTest.java to ensure the fix for inline node-pattern property filters with parameters is robust and prevents future regressions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• engine/src/main/java/com/arcadedb/query/opencypher/executor/steps/MatchNodeStep.java
  • Added logic to handle CypherASTBuilder.ParameterReference objects for parameter resolution.
  • Updated comments to distinguish between ParameterReference objects and legacy string-based parameter references.
• engine/src/test/java/com/arcadedb/query/opencypher/ParameterTest.java
  • Introduced a new test method inlineNodePatternParameterMatching to specifically test the fix for inline node-pattern parameter matching.

Activity

• The author, ExtReMLapin, created the pull request to fix issue Cypher : Fail to match when key is a param #3476.
• The fix was reportedly written by "Claude" and verified by the author after resolving a compilation loop bug.
• The author confirmed that the build passed (mvn clean package) and unit tests cover both failure and success scenarios.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[mergify]

🧪 CI Insights

Here's what we observed from your CI run for bdfb377.

🟢 All jobs passed!

But CI Insights is watching 👀

[gemini-code-assist]

Code Review

This pull request introduces a crucial fix for parameter resolution within MATCH clauses, specifically addressing cases where parameters are represented as ParameterReference objects. The MatchNodeStep.java file now correctly resolves these parameters, ensuring that property filters in node patterns function as expected. A new regression test in ParameterTest.java has been added to validate this fix, demonstrating that inline node-pattern parameter matching now works correctly. This significantly improves the robustness and correctness of Cypher query execution.

[gemini-code-assist]

If paramValue is null (meaning the parameter was not found or explicitly set to null), expectedValue will remain a CypherASTBuilder.ParameterReference object. This can lead to incorrect comparisons later in the matchesProperties method, as a ParameterReference object will be compared directly against a vertex property value, or potentially cause a ClassCastException if subsequent logic expects a String or null. The expectedValue should be set to null if the parameter resolves to null.

Suggested change

	if (paramValue != null)
	expectedValue = paramValue;
	expectedValue = paramValue;

[lvca]

Fixed manually