Updating to use some C# patterns #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 16, 2025 23:25
added 3 commits
November 17, 2025 00:18
jottakka
changed the title
jottakka
changed the title
jottakka
commented
Nov 17, 2025
examples/BasicExample/Program.cs
Outdated
|
|
||
| var result = await client.Tools.Execute(executeParams); | ||
| result.Validate(); | ||
|
|
Author
There was a problem hiding this comment.
Note to self: I did not tested with a tool that wasn't authorized already.
I must do it before merging.
added 3 commits
November 17, 2025 20:27
- IHttpClientFactory support with named clients - ASP.NET Core DI extensions (AddArcadeClient) - 5 DI tests (all passing) - ASP.NET Core example project - Pre-commit hooks - PR template - .gitattributes for generated files - Consolidated TryParseBaseUrl 18 files changed, 739 insertions(+), 182 deletions(-)
jottakka
force-pushed
the
francisco/update-cs-patterns
branch
from
48c61ae to
5358b4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor: Modern C# Patterns & Improved Architecture
Key Changes
Breaking:
ArcadeClientOptionsinstead of object initializerHttpClientremoved from public API, inject viaArcadeClientOptions.HttpClientHttpRequest/HttpResponse→ArcadeRequest/ArcadeResponse(ASP.NET conflict)New Features:
ArcadeClientOptions- strongly-typed configuration with env var supportArcadeClientFactory.Create()- convenient factory methods with shared HttpClientARCADE_API_KEYandARCADE_BASE_URLenv varsImprovements:
HttpClientVersion:
0.1.0→0.2.0Verified: Real API integration tests pass ✅