refactor(client): move some defaults out of ClientOptions

stainless-app[bot] · stainless-app[bot] · commit 3274d7579686 · 2025-11-13T04:28:38.000Z
diff --git a/src/ArcadeDotnet/Core/HttpResponse.cs b/src/ArcadeDotnet/Core/HttpResponse.cs
@@ -1,5 +1,4 @@
 using System;
-using System.IO;
 using System.Net.Http;
 using System.Text.Json;
 using System.Threading;
@@ -23,7 +22,7 @@ public async Task<T> Deserialize<T>(CancellationToken cancellationToken = defaul
         try
         {
             return JsonSerializer.Deserialize<T>(
-                    await this.ReadAsStream(cts.Token).ConfigureAwait(false),
+                    await Message.Content.ReadAsStreamAsync(cts.Token).ConfigureAwait(false),
                     ModelBase.SerializerOptions
                 ) ?? throw new ArcadeInvalidDataException("Response cannot be null");
         }
@@ -33,15 +32,6 @@ await this.ReadAsStream(cts.Token).ConfigureAwait(false),
         }
     }
 
-    public async Task<Stream> ReadAsStream(CancellationToken cancellationToken = default)
-    {
-        using var cts = CancellationTokenSource.CreateLinkedTokenSource(
-            this.CancellationToken,
-            cancellationToken
-        );
-        return await Message.Content.ReadAsStreamAsync(cts.Token).ConfigureAwait(false);
-    }
-
     public async Task<string> ReadAsString(CancellationToken cancellationToken = default)
     {
         using var cts = CancellationTokenSource.CreateLinkedTokenSource(

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`using System;`
`2`		`-using System.IO;`
`3`	`2`	`using System.Net.Http;`
`4`	`3`	`using System.Text.Json;`
`5`	`4`	`using System.Threading;`
`@@ -23,7 +22,7 @@ public async Task<T> Deserialize<T>(CancellationToken cancellationToken = defaul`
`23`	`22`	`try`
`24`	`23`	`{`
`25`	`24`	`return JsonSerializer.Deserialize<T>(`
`26`		`- await this.ReadAsStream(cts.Token).ConfigureAwait(false),`
	`25`	`+ await Message.Content.ReadAsStreamAsync(cts.Token).ConfigureAwait(false),`
`27`	`26`	`ModelBase.SerializerOptions`
`28`	`27`	`) ?? throw new ArcadeInvalidDataException("Response cannot be null");`
`29`	`28`	`}`
`@@ -33,15 +32,6 @@ await this.ReadAsStream(cts.Token).ConfigureAwait(false),`
`33`	`32`	`}`
`34`	`33`	`}`
`35`	`34`
`36`		`- public async Task<Stream> ReadAsStream(CancellationToken cancellationToken = default)`
`37`		`- {`
`38`		`- using var cts = CancellationTokenSource.CreateLinkedTokenSource(`
`39`		`- this.CancellationToken,`
`40`		`- cancellationToken`
`41`		`- );`
`42`		`- return await Message.Content.ReadAsStreamAsync(cts.Token).ConfigureAwait(false);`
`43`		`- }`
`44`		`-`
`45`	`35`	`public async Task<string> ReadAsString(CancellationToken cancellationToken = default)`
`46`	`36`	`{`
`47`	`37`	`using var cts = CancellationTokenSource.CreateLinkedTokenSource(`