feat: add default favicon

Author: AquilaSands

DevWebServer.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk.Web">
+<Project Sdk="Microsoft.NET.Sdk.Web">
 
   <PropertyGroup>
     <TargetFramework>netcoreapp2.2</TargetFramework>
@@ -10,4 +10,8 @@
     <PackageReference Include="Microsoft.AspNetCore.Razor.Design" Version="2.2.0" PrivateAssets="All" />
   </ItemGroup>
 
+  <ItemGroup>
+    <None Include="favicon.ico" CopyToPublishDirectory="PreserveNewest" />
+  </ItemGroup>
+
 </Project>

Program.cs

@@ -1,6 +1,4 @@
 using System;
-using System.Collections;
-using System.Collections.Generic;
 using System.Diagnostics;
 using System.IO;
 using Microsoft.AspNetCore;

SecureHeaderMiddleware.cs

@@ -34,11 +34,6 @@ public Task InvokeAsync(HttpContext context)
                     {
                         headers[headerValuePair.Key] = headerValuePair.Value;
                     }
-
-                    // foreach (var header in result.RemoveHeaders)
-                    // {
-                    //     headers.Remove(header);
-                    // }
                 }
 
                 return Task.CompletedTask;

Startup.cs

@@ -2,6 +2,7 @@
 using System.Diagnostics;
 using Microsoft.AspNetCore.Builder;
 using Microsoft.AspNetCore.Hosting;
+using Microsoft.AspNetCore.Http;
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.FileProviders;
@@ -38,6 +39,27 @@ public void Configure(IApplicationBuilder app, IHostingEnvironment env,
                 app.UseMiddleware<SecureHeaderMiddleware>();
             }
 
+            // Provide default favicon if one is not specified in the html to prevent 404
+            // This will probably prevent using a favicon with the default 'favicon.ico' name
+            app.Use(async (context, next) =>
+            {
+                if (context.Request.Path.Equals("/favicon.ico", StringComparison.OrdinalIgnoreCase))
+                {
+                    var fileInfo = env.ContentRootFileProvider.GetFileInfo("favicon.ico");
+
+                    if (fileInfo.Exists)
+                    {
+                        HttpResponse response = context.Response;
+                        response.StatusCode = StatusCodes.Status200OK;
+                        response.ContentType = "image/vnd.microsoft.icon";
+                        await response.SendFileAsync(fileInfo);
+                        return;
+                    }
+                }
+
+                await next();
+            });
+
             var config = configAccessor.Value;
 
             Console.WriteLine($"Serving files from path {config.BaseDirectory}");