Skip to content

Commit af7c264

Browse files
authored
Merge pull request #343 from AppQuality/campaign-dash-mobile-fixes
Campaign-dash-mobile-fixes
2 parents 251e709 + 7c8a6f7 commit af7c264

File tree

2 files changed

+26
-16
lines changed

2 files changed

+26
-16
lines changed

src/pages/Campaign/index.tsx

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ const Campaign = () => {
8181
<EmptyState />
8282
) : (
8383
<>
84-
<Col xs={12} md={3}>
84+
<Col xs={12} xl={3}>
8585
{isLoadingCampaign ||
8686
isFetchingCampaign ||
8787
isLoadingReports ||
@@ -96,7 +96,7 @@ const Campaign = () => {
9696
/>
9797
)}
9898
</Col>
99-
<Col xs={12} md={9}>
99+
<Col xs={12} xl={9}>
100100
{campaign?.outputs?.includes('bugs') && (
101101
<>
102102
<WidgetSection id="campaign-overview">
@@ -107,13 +107,13 @@ const Campaign = () => {
107107
)}
108108
/>
109109
</Col>
110-
<Col xs={12} md={4}>
110+
<Col xs={12} sm={6} xl={4}>
111111
<Progress campaign={campaign} />
112112
</Col>
113-
<Col xs={12} md={4}>
113+
<Col xs={12} sm={6} xl={4}>
114114
<UniqueBugs campaignId={campaign ? campaign.id : 0} />
115115
</Col>
116-
<Col xs={12} md={4} lg={4}>
116+
<Col xs={12} sm={6} xl={4}>
117117
{isFetchingCampaign ? undefined : (
118118
<BugDistributionCard
119119
campaignId={campaign ? campaign.id : 0}
@@ -130,10 +130,10 @@ const Campaign = () => {
130130
)}
131131
/>
132132
</Col>
133-
<Col xs={12} md={6}>
133+
<Col xs={12} xl={6}>
134134
<UniqueBugs4UseCase height={firstRowHeight} />
135135
</Col>
136-
<Col xs={12} md={6}>
136+
<Col xs={12} xl={6}>
137137
<IncomingBugs
138138
height={firstRowHeight}
139139
campaignId={campaign.id ?? 0}
@@ -151,13 +151,13 @@ const Campaign = () => {
151151
)}
152152
/>
153153
</Col>
154-
<Col xs={12} md={6}>
154+
<Col xs={12} xl={6}>
155155
<TotalBugsByOsAndDevices
156156
height={secondRowHeight}
157157
campaignId={campaign.id ?? 0}
158158
/>
159159
</Col>
160-
<Col xs={12} md={6}>
160+
<Col xs={12} xl={6}>
161161
<BugsByType
162162
height={secondRowHeight}
163163
campaignId={campaign.id ?? 0}

src/pages/Campaign/widgets/List/ListItem.tsx

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,24 @@
1-
import { SM, Progress, MD, Span } from '@appquality/unguess-design-system';
1+
import {
2+
SM,
3+
Progress,
4+
MD,
5+
Span,
6+
Ellipsis,
7+
} from '@appquality/unguess-design-system';
28
import { theme as globalTheme } from 'src/app/theme';
39
import styled from 'styled-components';
410
import { ListItemProps } from './type';
511

612
const ListItemTitle = styled.div`
7-
display: flex;
8-
align-items: center;
9-
justify-content: space-between;
13+
display: grid;
14+
grid-template-columns: 9fr 1fr;
1015
padding-top: ${({ theme }) => theme.space.xs};
1116
padding-bottom: ${({ theme }) => theme.space.xxs};
1217
`;
1318

1419
const ListItemWrapper = styled.div`
1520
margin-top: ${(p) => p.theme.space.xxs};
21+
display: block;
1622
`;
1723

1824
export const ListItem = ({
@@ -22,10 +28,14 @@ export const ListItem = ({
2228
}: ListItemProps) => (
2329
<ListItemWrapper>
2430
<ListItemTitle>
25-
<MD isBold style={{ color: globalTheme.palette.blue[600] }}>
26-
{children}
31+
<MD
32+
isBold
33+
style={{ color: globalTheme.palette.blue[600], display: 'contents' }}
34+
>
35+
<Ellipsis style={{ width: '97%' }}>{children}</Ellipsis>
2736
</MD>
28-
<SM style={{ color: globalTheme.palette.grey[600] }}>
37+
38+
<SM style={{ color: globalTheme.palette.grey[600], justifySelf: 'end' }}>
2939
<Span isBold style={{ color: globalTheme.palette.grey[700] }}>
3040
{numerator}
3141
</Span>

0 commit comments

Comments
 (0)