-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for zstd compression #193
Comments
There is a pull request that did not get merged so far, maybe it can be reactivated: |
Currently we are using vasi/squashfuse@1f98030 from 2016. We should probably use a more recent version. The changes would need to be made around here: libappimage/cmake/dependencies.cmake Lines 85 to 104 in e56c21b
and libappimage/ci/install-deps.sh Line 56 in e56c21b
It seems that @TheAssassin had invested a lot of time to think about internal vs. external building (rather than my typical style of coding "linearly" to make it work in exactly one "known good" configuration), so I'll leave it up to him to add zstd support in order not to inadvertently break this flexibility. |
We are trying to standardize on zstd (no pun intended). So if libappiage doesn't support it yet, it would be highly appreciated if someone could add it.
@philmb3487 over at AppImage/appimagetool#68 (comment):
Some people are generating AppImages with
zstd
compression, and that is not supported out of the box by libappimage.Now, that is fine for executing AppImages, but file thumbnailers such as KDE's Dolphin use libappimage.so directly to peek at the .DirIcon information, which fails for
zstd
images.Would it be possible to add this support?
Arch Linux seems to enable fuse to get that support, squashfuse then needs to be compiled with
zstd
support turned on. That's a lot of switches that might or might not be enabled, depending on the distribution, and I think thumbnails should always be available in any case.See my findings here,
ivan-hc/Steam-appimage#27 (comment)
So, I propose either,
The text was updated successfully, but these errors were encountered: