Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] How to modify the domain name of uploaded images #6385

Open
smartyhero opened this issue Sep 23, 2024 · 2 comments
Open

[Bug] How to modify the domain name of uploaded images #6385

smartyhero opened this issue Sep 23, 2024 · 2 comments
Labels
bug Something isn't working self-hosted

Comments

@smartyhero
Copy link

Bug Description

Self-hosted appflowy
I uploaded the image normally
When I changed the domain name used by my self-hosted appflowy, how can I change the domain name of the original link for uploading the image?

How to Reproduce

Use a.com to upload images
Change the domain name of the self-hosted appflowy to b.com
How to make the uploaded images also use b.com

Expected Behavior

I can configure the domain name for uploading pictures

Operating System

mac

AppFlowy Version(s)

0.6.9

Screenshots

No response

Additional Context

No response

@Xazin
Copy link
Collaborator

Xazin commented Sep 24, 2024

This seems to be due to using an environment variable inside flowy-server crate, which means the base_url is always the same unless the application is built by the self-hoster with preset environment variables.

We should of course set the base url according to the inputted self-host url, we can instead default it to the environment variable if none provided. (eg. in a small locally cached sqlite table containing the configuration).

CC @appflowy

@Xazin Xazin added the bug Something isn't working label Sep 24, 2024
@smartyhero
Copy link
Author

The publish function of self-hosted appflowy also has a similar domain name problem. The domain name displayed after publish is appflowy.com
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working self-hosted
Projects
None yet
Development

No branches or pull requests

2 participants