Skip to content

Commit 106530d

Browse files
committed
Countly with args
1 parent 6eb001e commit 106530d

File tree

7 files changed

+19
-17
lines changed

7 files changed

+19
-17
lines changed

LogcatCoreLib/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,5 +27,5 @@ dependencies {
2727
implementation 'com.google.code.gson:gson:2.8.6'
2828
implementation 'androidx.recyclerview:recyclerview:1.1.0'
2929
api 'com.google.android.material:material:1.2.1'
30-
api 'com.jakewharton.timber:timber:4.7.1'
30+
api 'com.github.hannesa2:Timber:4.7.1.0'
3131
}

LogcatCoreLib/src/main/java/info/hannes/timber/DebugTree.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,7 @@ open class DebugTree : Timber.DebugTree() {
1717
)
1818
}
1919

20-
// if there is an JSON string, try to print out pretty
21-
override fun log(priority: Int, tag: String?, message: String, t: Throwable?) {
20+
override fun logMessage(priority: Int, tag: String?, message: String, t: Throwable?, vararg args: Any?) {
2221
var localMessage = message.trim()
2322
if (localMessage.startsWith("{") && localMessage.endsWith("}")) {
2423
val json = JSONObject(message)
@@ -27,6 +26,7 @@ open class DebugTree : Timber.DebugTree() {
2726
} catch (e: JSONException) {
2827
}
2928
}
30-
super.log(priority, tag, localMessage, t)
29+
super.logMessage(priority, tag, localMessage, t, *args)
3130
}
31+
3232
}

LogcatCoreLib/src/main/java/info/hannes/timber/FileLoggingTree.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ open class FileLoggingTree(externalCacheDir: File, context: Context? = null, fil
3434
}
3535

3636
@SuppressLint("LogNotTimber")
37-
override fun log(priority: Int, tag: String?, message: String, t: Throwable?) {
37+
override fun logMessage(priority: Int, tag: String?, message: String, t: Throwable?, vararg args: Any?) {
3838
try {
3939
val logTimeStamp = SimpleDateFormat("yyyy-MM-dd HH:mm:ss:SSS", Locale.getDefault()).format(Date())
4040

LogcatCountlyLib/src/main/java/info/hannes/countly/Analytics.kt

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,15 @@ class Analytics : IAnalytics {
2121
return countlyInstance.isInitialized
2222
}
2323

24-
override fun recordEvent(event: String) {
24+
private fun toPair(vararg args: Any?) = args.map { param -> Pair(param.toString(), param.toString()) }
25+
26+
override fun recordEvent(event: String, vararg args: Any?) {
2527
if (isInitialized()) {
26-
countlyInstance.events().recordEvent(event, segmentation, 1)
28+
countlyInstance.events().recordEvent(event, segmentation.plus(toPair(args)), 1)
2729
}
2830
}
2931

30-
override fun recordError(message: String) {
32+
override fun recordError(message: String, vararg args: Any?) {
3133
if (isInitialized()) {
3234
countlyInstance.crashes().recordHandledException(RuntimeException(message))
3335
}
@@ -39,7 +41,7 @@ class Analytics : IAnalytics {
3941
}
4042
}
4143

42-
override fun recordWarning(message: String) {
44+
override fun recordWarning(message: String, vararg args: Any?) {
4345
if (isInitialized()) {
4446
countlyInstance.crashes().recordHandledException(RuntimeException(message))
4547
}

LogcatCountlyLib/src/main/java/info/hannes/countly/IAnalytics.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@ interface IAnalytics {
66

77
fun isInitialized(): Boolean
88

9-
fun recordEvent(event: String)
9+
fun recordEvent(event: String, vararg args: Any?)
1010

11-
fun recordWarning(message: String)
11+
fun recordWarning(message: String, vararg args: Any?)
1212

13-
fun recordError(message: String)
13+
fun recordError(message: String, vararg args: Any?)
1414

1515
fun recordError(throwable: Throwable)
1616

LogcatCountlyLib/src/main/java/info/hannes/timber/CountlyTree.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class CountlyTree(private val analytics: Analytics, private val serverIgnoreToke
1919
private val t = serverIgnoreToken
2020
private val regex: Regex = "$t.+?$t|$t[^$t]*$".toRegex()
2121

22-
override fun log(priority: Int, tag: String?, message: String, throwable: Throwable?) {
22+
override fun logMessage(priority: Int, tag: String?, message: String, t: Throwable?, vararg args: Any?) {
2323
// we ignore INFO, DEBUG and VERBOSE
2424
if (priority <= Log.INFO) {
2525
return
@@ -30,9 +30,9 @@ class CountlyTree(private val analytics: Analytics, private val serverIgnoreToke
3030
}
3131

3232
when {
33-
throwable != null -> analytics.recordError(throwable)
34-
priority == Log.WARN -> analytics.recordEvent(localMessage)
35-
else -> analytics.recordError(localMessage)
33+
t != null -> analytics.recordError(t)
34+
priority == Log.WARN -> analytics.recordEvent(localMessage, args)
35+
else -> analytics.recordError(localMessage, args)
3636
}
3737
}
3838

LogcatCrashlyticLib/src/main/java/info/hannes/crashlytic/CrashlyticsTree.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import java.util.concurrent.atomic.AtomicBoolean
88
@Suppress("unused")
99
class CrashlyticsTree(private val identifier: String? = null) : Timber.Tree() {
1010

11-
override fun log(priority: Int, tag: String?, message: String, t: Throwable?) {
11+
override fun logMessage(priority: Int, tag: String?, message: String, t: Throwable?, vararg args: Any?) {
1212
if (priority < Log.INFO) {
1313
return
1414
}

0 commit comments

Comments
 (0)