Add specification tests for jitter#2830
Merged
Merged
Conversation
Add some specification tests for the application of jitter in retries using FsCheck.
martincostello
added
enhancement
dependencies
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2830 +/- ##
=======================================
Coverage 96.15% 96.15%
=======================================
Files 309 309
Lines 7123 7123
Branches 1005 1005
=======================================
Hits 6849 6849
Misses 221 221
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Pull request overview
This pull request adds property-based specification tests for retry jitter functionality using the FsCheck framework. The changes enable comprehensive testing of jitter algorithms by generating and validating thousands of random test cases.
Key changes:
- Added two FsCheck property-based tests to verify
ApplyJitterandDecorrelatedJitterBackoffV2behavior - Made two retry helper methods internal to enable direct testing
- Added FsCheck.Xunit package dependency (version 3.3.2)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| test/Polly.Core.Tests/Retry/RetryHelperTests.cs | Added property-based tests with custom arbitraries for generating test data, and changed helper method visibility |
| src/Polly.Core/Retry/RetryHelper.cs | Changed two methods from private to internal to enable testing, and reorganized code (moved methods) |
| test/Polly.Core.Tests/Polly.Core.Tests.csproj | Added FsCheck.Xunit package reference for property-based testing |
| Directory.Packages.props | Added FsCheck.Xunit version specification (3.3.2) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
martincostello
added a commit
that referenced
this pull request
Nov 24, 2025
Apply recommendations/fixes suggested by Copilot in #2830.
martincostello
added a commit
that referenced
this pull request
Nov 24, 2025
Apply recommendations/fixes suggested by Copilot in #2830.
This was referenced Mar 4, 2026
Closed
Bump Polly.Core and Polly.RateLimiting
ProReception/ProReception.DistributionServerInfrastructure#41
Closed
This was referenced May 10, 2026
This was referenced May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some specification tests for the application of jitter in retries using FsCheck.