Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CA1816 NoWarn #2317

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Remove CA1816 NoWarn #2317

merged 1 commit into from
Sep 29, 2024

Conversation

gabidabet
Copy link
Contributor

Pull Request

The issue or feature being addressed

#1290

Details on the issue fix or feature implementation

File Fix introduced
TimeLock The warning exists only in a Debug section so I preferred a local suppression
AsyncBulkheadPolicy Add GC.SuppressFinalize(this); at the end f Dispose
BulkheadPolicy Add GC.SuppressFinalize(this); at the end f Dispose

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.39%. Comparing base (856bfdf) to head (0aba298).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2317   +/-   ##
=======================================
  Coverage   85.38%   85.39%           
=======================================
  Files         313      313           
  Lines        7457     7461    +4     
  Branches     1126     1126           
=======================================
+ Hits         6367     6371    +4     
  Misses        745      745           
  Partials      345      345           
Flag Coverage Δ
linux 85.36% <100.00%> (+<0.01%) ⬆️
macos 85.39% <100.00%> (+<0.01%) ⬆️
windows 85.36% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gabidabet
Copy link
Contributor Author

Reading multiple blogs, I don't know if adding GC.SuppressFinalize(this); at the end of Dispose is a good approach.

@martincostello martincostello merged commit 25e57e4 into App-vNext:main Sep 29, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants