Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warning CA1805 #2221

Merged

Conversation

Fanatic-off
Copy link
Contributor

@Fanatic-off Fanatic-off commented Jul 21, 2024

#1290 Cleanup codebase

@dotnet-policy-service agree

  • Suppress CA1805 in the code or fix the warning
  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martincostello
Copy link
Member

#2032 (comment)

@Fanatic-off
Copy link
Contributor Author

@dotnet-policy-service agree

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.92%. Comparing base (87cfed7) to head (2b5e2be).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2221   +/-   ##
=======================================
  Coverage   83.91%   83.92%           
=======================================
  Files         313      313           
  Lines        7187     7191    +4     
  Branches     1064     1066    +2     
=======================================
+ Hits         6031     6035    +4     
  Misses        785      785           
  Partials      371      371           
Flag Coverage Δ
linux 83.92% <ø> (+<0.01%) ⬆️
macos 83.92% <ø> (+<0.01%) ⬆️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello enabled auto-merge (squash) July 21, 2024 20:07
@martincostello martincostello merged commit 4e05ea1 into App-vNext:main Jul 21, 2024
15 checks passed
@Fanatic-off Fanatic-off deleted the fanatic-off/remove-warning-ca1805 branch July 21, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants