Fix retry overflow with max delay#1868
Merged
martincostello merged 2 commits intoDec 26, 2023
Merged
Conversation
Contributor
Author
|
@dotnet-policy-service agree |
martincostello
approved these changes
Dec 26, 2023
Member
martincostello
left a comment
There was a problem hiding this comment.
Just one minor suggestion.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1868 +/- ##
=======================================
Coverage 84.58% 84.59%
=======================================
Files 308 308
Lines 6799 6801 +2
Branches 1049 1050 +1
=======================================
+ Hits 5751 5753 +2
Misses 839 839
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
martincostello
pushed a commit
that referenced
this pull request
Jan 4, 2024
This was referenced Aug 26, 2025
This was referenced Sep 29, 2025
This was referenced Jan 16, 2026
This was referenced Mar 26, 2026
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
The issue or feature being addressed
Fix issue #1866 Retry Startegy stops retrying unexpectedly
Details on the issue fix or feature implementation
In case computing retry delay throws
OverflowException,RetryHelper.GetRetryDelay(...)returnsmaxDelay.valueif not null,TimeSpan.MaxValueotherwise.Confirm the following