Calculated break duration for Circuit breaker #1715
Closed
atawLee wants to merge 0 commit into
Closed
Conversation
Contributor
Author
|
@dotnet-policy-service agree |
martintmk
requested changes
Oct 22, 2023
Contributor
|
Please also update the related anti-pattern under the circuit breaker docs. |
peter-csala
reviewed
Oct 27, 2023
martintmk
reviewed
Oct 28, 2023
martintmk
reviewed
Oct 28, 2023
martintmk
reviewed
Oct 28, 2023
martintmk
reviewed
Oct 28, 2023
martintmk
reviewed
Oct 28, 2023
martintmk
reviewed
Oct 28, 2023
martintmk
reviewed
Oct 30, 2023
martintmk
reviewed
Oct 31, 2023
martintmk
reviewed
Oct 31, 2023
martintmk
reviewed
Oct 31, 2023
martintmk
reviewed
Oct 31, 2023
martintmk
reviewed
Oct 31, 2023
martintmk
reviewed
Oct 31, 2023
martintmk
reviewed
Oct 31, 2023
Member
martincostello
left a comment
There was a problem hiding this comment.
Please run the build locally and fix the analyser warnings that are reported to you, such as code formatting issues and the Public API Analyser warnings. Opening the code with Visual Studio should provide you with gestures on the analyzer warnings to automatically update the appropriate files.
Member
|
The build is now complaining about not all of the changes' code paths being covered by a test. You can use the coverage report attached to the build artifacts to take a look at what is missing. |
5448c32 to
41fd38c
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
The issue or feature being addressed
#653
Details on the issue fix or feature implementation
FailureCountget property toCircuitBehaviorto retrieve the count of failures._breakDurationGeneratorof typeFunc<int, TimeSpan>toCircuitStateControllerfor dynamic break duration generation.CircuitStateControllerwith an overload to accommodate_breakDurationGenerator.FailureCountintoHealthInfo.OpenCircuitFor_NeedsLockto assign the_blockedUntilvalue based on both the presence ofbreakDurationand the number of failures.Confirm the following