Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Remove theme overwrites from mermaid diagrams #1705

Conversation

peter-csala
Copy link
Contributor

@peter-csala peter-csala commented Oct 18, 2023

Pull Request

The issue or feature being addressed

Details on the issue fix or feature implementation

  • The bug fix has been released today (link)
  • We can remove the theme overwrites and enjoy the built-in support

Proof

Dark

Screenshot 2023-10-18 at 16 52 45

Light

Screenshot 2023-10-18 at 16 53 09

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 😃

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (46978cf) 84.65% compared to head (5b4c30e) 84.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1705   +/-   ##
=======================================
  Coverage   84.65%   84.65%           
=======================================
  Files         306      306           
  Lines        6831     6831           
  Branches     1047     1047           
=======================================
  Hits         5783     5783           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux ?
macos 84.65% <ø> (ø)
windows 84.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peter-csala peter-csala changed the title Remove theme overwrites [Docs] Remove theme overwrites from mermaid diagrams Oct 18, 2023
@martincostello martincostello enabled auto-merge (squash) October 18, 2023 15:04
@martincostello martincostello merged commit d9fe9c9 into App-vNext:main Oct 18, 2023
18 checks passed
@peter-csala peter-csala deleted the upgrade-docfx-to-support-dynamic-theme-change-for-mermaid branch October 31, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants