Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ExecuteCoreAsync to ExecuteCore #1424

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jul 24, 2023

Details on the issue fix or feature implementation

For context:
#1233 (comment)

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jul 24, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jul 24, 2023
src/Polly.Core/ResilienceStrategy.cs Outdated Show resolved Hide resolved
src/Polly.Core/ResilienceStrategy.cs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #1424 (6585540) into main (7199f75) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1424   +/-   ##
=======================================
  Coverage   83.92%   83.92%           
=======================================
  Files         275      275           
  Lines        6526     6526           
  Branches     1007     1007           
=======================================
  Hits         5477     5477           
  Misses        840      840           
  Partials      209      209           
Flag Coverage Δ
linux ?
macos 83.92% <100.00%> (ø)
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Polly.Core/NullResilienceStrategy.cs 100.00% <ø> (ø)
...rc/Polly.Core/Timeout/TimeoutResilienceStrategy.cs 100.00% <ø> (ø)
src/Polly.Core/Utils/OutcomeResilienceStrategy.cs 100.00% <ø> (ø)
src/Polly.Core/Utils/TimeProviderExtensions.cs 100.00% <ø> (ø)
...xtensions/Telemetry/TelemetryResilienceStrategy.cs 100.00% <ø> (ø)
...olly.RateLimiting/RateLimiterResilienceStrategy.cs 100.00% <ø> (ø)
...c/Polly.Core/ResilienceStrategy.Async.ValueTask.cs 100.00% <100.00%> (ø)
.../Polly.Core/ResilienceStrategy.Async.ValueTaskT.cs 100.00% <100.00%> (ø)
src/Polly.Core/ResilienceStrategy.cs 100.00% <100.00%> (ø)
...c/Polly.Core/Utils/ReloadableResilienceStrategy.cs 100.00% <100.00%> (ø)
... and 1 more

@martintmk martintmk enabled auto-merge (squash) July 24, 2023 06:16
@martintmk martintmk merged commit b9ce232 into main Jul 24, 2023
12 checks passed
@martintmk martintmk deleted the mtomka/ExecuteCoreAsync-rename branch July 24, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants