-
Notifications
You must be signed in to change notification settings - Fork 0
SCRUM-275/308: Nuxt Fe(feature): Enable supervisors to accept/dismiss/add as supervisee students from their profile page #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables supervisors to manage supervisee relationships directly from student profile pages by fetching pending requests and providing UI actions to add, accept, or dismiss students.
- Introduces a
getSupervisionRequestsaction in the supervisor store to load pending supervision requests. - Refactors matching and profile pages to use the store, adds buttons and modals for accepting, dismissing, or adding students as supervisees.
- Updates localization files and README to document new workflows and environment setup.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Frontend/stores/useSupervisorStore.ts | Adds getSupervisionRequests action to fetch pending requests |
| Frontend/pages/supervisor/matching.vue | Fetches requests on mount and removes inline fetch logic |
| Frontend/pages/profiles/[id].vue | Adds supervisee management buttons, modal configuration, and handlers |
| Frontend/i18n/locales/en-GB.json & de-DE.json | Adds translation keys for manage/add/handle supervision requests |
| Frontend/components/ConfirmationModal/ConfirmationModal.vue | Switches to dynamic props.icon and click handler on icon |
| Frontend/README.md | Expands project README with tech stack, features, and setup steps |
| Frontend/.env.example | Clarifies environment variable placeholders and allowed domains |
Comments suppressed due to low confidence (3)
Frontend/pages/profiles/[id].vue:71
- The supervisee management buttons are rendered based only on the profile user's role (
isStudent), but you also need to ensure the current user is a supervisor (currentUser?.role === UserRoles.SUPERVISOR) to prevent other roles (e.g., admins) from seeing these actions.
"
Frontend/pages/profiles/[id].vue:290
- [nitpick] The function name
manageAddAsSuperviseeis ambiguous when compared toaddStudentAsSupervisee. Consider renaming it to something more descriptive likeopenAddSuperviseeModalto clearly convey its purpose.
const manageAddAsSupervisee = () => {
Frontend/README.md:6
- There's a typo here: "framwork" should be "framework". Also consider reviewing the rest of the README for typos like "I8ln", "managment", "compataibile", and "applicaiton".
## Tech stack
…nt pending request
055b56e to
c34c170
Compare
|
It all works nice! Just one small thing: When I am already supervising a student, then the button is still shown. It does not show the error from the backend, but that would be a nice to have. Bernhard also just implemented an endpoint to retrieve accepted requests from a user, if you want to do it that way --> #202 If you want you can already merge it like this, or add the above thing first and then merge. I will approve anyways :) |
…nt pending request
967cd29 to
5b3d30e
Compare
…/App-Dev-3/Superwise into SCRUM-308-Frontend-update-readme
…a supervisor already
Changed readme.
To test the #275 task.
Visit a student page that hasnt made any request to you -> u should be able to add him as supervisee
Visist a student page that has a pending request to u -> u should be able to accept/dismiss him