Run Rubocop when opening PR #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PanosCodes
force-pushed
the
run-rubocop-on-pr
branch
10 times, most recently
from
cd851ae
to
29bdce8
Compare
PanosCodes
force-pushed
the
run-rubocop-on-pr
branch
2 times, most recently
from
b1f059b
to
58388a0
Compare
PanosCodes
force-pushed
the
run-rubocop-on-pr
branch
from
58388a0
to
db66604
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could avoid having Rubocop violations merged into master if we run Robocop during PR
WDYT 🤔 ?
#825 & #827 will propably need to be merged first.