Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate parameters #819

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Deprecate parameters #819

merged 2 commits into from
Feb 13, 2023

Conversation

PanosCodes
Copy link
Contributor

@PanosCodes PanosCodes commented Feb 12, 2023 •
edited
Loading

Closes #811

image

@PanosCodes PanosCodes force-pushed the deprecate-parameters branch 2 times, most recently from 7cf3efd to 22d0357 Compare February 12, 2023 06:49
@PanosCodes PanosCodes marked this pull request as ready for review February 12, 2023 06:51
mathieujobin
mathieujobin reviewed Feb 13, 2023
View reviewed changes
Copy link
Collaborator

@mathieujobin mathieujobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the empty lib/apipie/viewer/renderer.rb file ?

@PanosCodes
Copy link
Contributor Author

why the empty lib/apipie/viewer/renderer.rb file ?

By mistake 😅, gone

@mathieujobin mathieujobin merged commit b56349a into Apipie:master Feb 13, 2023
@PanosCodes PanosCodes deleted the deprecate-parameters branch March 28, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathieujobin mathieujobin Awaiting requested review from mathieujobin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mark params as deprecated
2 participants
@PanosCodes @mathieujobin