Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style/PreferredHashMethods-20220909233727 #781

Merged
merged 5 commits into from
Jan 16, 2023
Merged

Style/PreferredHashMethods-20220909233727 #781

merged 5 commits into from
Jan 16, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 9, 2022

Rubocop challenge!

Style/PreferredHashMethods

Safe autocorrect: No
⚠️ The autocorrect a cop can yield false positives by design.

Description

Overview

Checks for uses of methods Hash#has_key? and
Hash#has_value?, and suggests using Hash#key? and Hash#value? instead.

It is configurable to enforce the verbose method names, by using the
EnforcedStyle: verbose configuration.

Examples

EnforcedStyle: short (default)

# bad
Hash#has_key?
Hash#has_value?

# good
Hash#key?
Hash#value?

EnforcedStyle: verbose

# bad
Hash#key?
Hash#value?

# good
Hash#has_key?
Hash#has_value?

Auto generated by rubocop_challenger

mathieujobin
mathieujobin approved these changes Sep 10, 2022
View reviewed changes
Copy link
Collaborator

@mathieujobin mathieujobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge in a few weeks unless objections

@mathieujobin mathieujobin merged commit b8a7ef4 into master Jan 16, 2023
@mathieujobin mathieujobin deleted the rubocop-challenge/20220909233727 branch January 16, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathieujobin mathieujobin mathieujobin approved these changes

Assignees
No one assigned
Labels
rubocop challenge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mathieujobin