Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds swagger tags in swagger output #634

Merged

Conversation

enrique-guillen
Copy link
Contributor

@enrique-guillen enrique-guillen commented Oct 13, 2018

Addresses issue #632, by adding a single #tags DSL method.

Has a swagger_dsl_spec example now (among others), and the tags are queried for in SwaggerGenerator (see response_validation_spec).

@enrique-guillen enrique-guillen force-pushed the feature/swagger-tags-in-swagger-output branch from 87d17cf to 5a4e3ba Compare October 14, 2018 04:23
@enrique-guillen enrique-guillen changed the title Adds swagger tags in swagger output [WIP] Adds swagger tags in swagger output Oct 14, 2018
@enrique-guillen
Copy link
Contributor Author

I wonder what's up with the "random" successes. CI failed a pair of times like the other 3 recent PRs, on the same example for the same Ruby & Rails combination.

@iNecas
Copy link
Member

iNecas commented Oct 15, 2018

Thank you @enrique-guillen, I've seen this errors as well: will need to investigate furter, but I'm pretty sure it's not related to this PR. I'm happy with the quality and thanks for the tests - it makes makes it much easier to accept the changes.

@iNecas
Copy link
Member

iNecas commented Oct 15, 2018

apipie-rails-0.5.11 was just pushed to rubygems, including this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants