Boolean Validator uses <code> instead of ' #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the Boolean Validator to output its message similarly to when you have array validations
|
Thanks @berfarah , Merging now |
|
apipie-rails-0.4.0 has just been released, including this enhancement. Thanks @berfarah for help! |
|
Happy to contribute, even if it was a tiny bit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the Boolean Validator to output its message similarly to when you have array validations
This:
Will now look like this:
when reading the documentation. This makes it clearer that you can pass in the literal values instead of strings of those values.
I can update the ArrayValidator to do the same thing –– I believe it's currently just the Enum one that outputs it with a code.