Add more options to apipie:cache #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| with_loaded_documentation do | ||
| puts "#{Time.now} | Documents loaded..." | ||
| ([nil] + Apipie.configuration.languages).each do |lang| | ||
| I18n.locale = lang || Apipie.configuration.default_locale | ||
| puts "#{Time.now} | Processing docs for #{lang}" | ||
| cache_dir = Apipie.configuration.cache_dir | ||
| cache_dir = ENV["OUT"] || Apipie.configuration.cache_dir |
There was a problem hiding this comment.
maybe APIPIE_CACHE_DIR woudl be better name for the env variable
There was a problem hiding this comment.
I used the same convention I found in other apipie tasks. I'd prefer to have them consistent, should I rename them all? I'd be concerned about backward compatibility though.
There was a problem hiding this comment.
Ah, haven't realized that, np then
|
The conditions in the rake task were fixed. |
|
Looks good, thanks! |
iNecas
added a commit
that referenced
this pull request
Jul 23, 2014
Add more options to apipie:cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds
cache_part=[index|resources]andOUT=/some/diroptions to rake taskapipie:cache.In our enviroment the API is quite big and with the localization it takes a lot of time to generate the cache. With these options I can pre-generate part of the cache during the build time to save some time during installation.