Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boolean validation failing #748

Closed
colinbruce opened this issue Apr 1, 2022 · 1 comment
Closed

Boolean validation failing #748

colinbruce opened this issue Apr 1, 2022 · 1 comment

Comments

@colinbruce
Copy link
Contributor

Since the release of 0.7.0 and the merging of #733 we've seen some errors with boolean paramteters.

pry(#<Apipie::ParamDescription>)> false.blank?
=> true

Therefore when sending a param with a value of false, not "false", it fails before even calling the validate method of BooleanValidator
I'm working on a fix, and will try and open a PR soon
@colinbruce
Copy link
Contributor Author

PR #749 hopefully addresses this issue with some tests to cover it 👍

@colinbruce colinbruce mentioned this issue Apr 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@colinbruce