-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract JSON compatibility checking code into a separate module #1214
Comments
I don't think this would be difficult. In fact, we have our own goal of relocating the JSON compatibility checking from apicurio-registry repository into the apicurio-data-models repository. But that will require a rewrite of the functionality and a new JSON Schema data model in apicurio-data-models, so that won't happen too soon. Before that happens, I don't think it would be a big problem isolating the current functionality into a separate module for re-use. @jsenko what do you think? |
Since there is no standard for JSON compatibility checking (AKAIK), are you willing to publish the work done in this repository as specification for JSON schema evolution? We can think of creating a separate repository something like I am open to contribute this. This is still an open item on json schema org repo, json-schema-org/json-schema-vocabularies#5 |
hi, I agree that moving it into a separate module should be OK for the short term. For the long term, we would like to relocate it into |
Thanks for confirming! I created a PR to refactor the code to modularize this. |
Fixed in #1302 |
One of our use-cases require the JSON compatibility checking feature of apicurio-registry. We want to know if it's possible to extract the JSON compatibility checker and related classes into a separately buildable module.
We cannot depend on the whole apicurio-registry repository as it would bring-in lot of dependencies like rest client, Protobuf, Avro, etc which we don't need.
Can we contribute this change?
The text was updated successfully, but these errors were encountered: