Update Apex.AI custom toolbar buttons #14
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Apex.AI custom toolbar buttons in CLion by modernizing external tools and removing deprecated ones. The changes streamline the toolset to focus on Bazel-based workflows and update script implementations.
- Consolidates and renames external tools to use consistent "package" naming convention
- Removes legacy tools that are no longer needed (copyright, cmake lint, cpplint, etc.)
- Updates working directories to use
$ProjectFileDir$instead of$ProjectFileDir$/..
Reviewed Changes
Copilot reviewed 6 out of 18 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/External Tools.xml | Updates external tool definitions, removes deprecated tools, and standardizes naming |
| customization.xml | Updates toolbar button references to match renamed tools |
| _bazel_fix_current_pkg.sh | Adds support for checker parameter to allow different fix operations |
| _bazel_clang_reformat_current_pkg.sh | Removes file as functionality is now handled by the generic fix script |
| _bazel_build_html_requirements.sh | Removes file as functionality is consolidated |
| _bazel_build_current_pkg.sh | Updates GCC platform from gcc9 to gcc11 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| exit 1 | ||
| fi | ||
| if [[ -n "$1" ]]; then | ||
| CHECKER="$1" |
There was a problem hiding this comment.
This should be CHECKER="$2" to correctly capture the checker parameter, since $1 is already used for FILE_PATH.
dongilchang
force-pushed
the
13-update-apexai-custom-toolbar-buttons
branch
from
ac159ce to
244f4bf
Compare
There was a problem hiding this comment.
Remove it we can reuse _bazel_build_current_pkg.sh to build the HTML requirement doc.
There was a problem hiding this comment.
Not sure about this. Can you please provide more details about how to use _bazel_build_current_pkg.sh to build the HTML requirement doc.
| <action id="Tool_External Tools_PCLint" icon="$APPLICATION_CONFIG_DIR$/settingsRepository/repository/icons/PCLint.png" /> | ||
| <action id="Tool_External Tools_PCLint (entire package)" icon="$APPLICATION_CONFIG_DIR$/settingsRepository/repository/icons/PCLint.png" /> | ||
| <action id="Tool_External Tools_Test Current Bazel" icon="$APPLICATION_CONFIG_DIR$/settingsRepository/repository/icons/Colcon_TestPkg.png" /> | ||
| <action id="Tool_External Tools_Axivion Check" icon="$APPLICATION_CONFIG_DIR$/settingsRepository/repository/icons/Axivion.png" /> |
There was a problem hiding this comment.
When I import the toolbars, the png images are not shown on my CLion. I think that $APPLICATION_CONFIG_DIR$ is not working. If I set the png file path with the absolute file path, it worked. I spent several hours to resolve it. but I couldn't. Do you have any idea?
There was a problem hiding this comment.
@dongilchang, can we postpone this PR for a week? After our 25.08 release validation week.
There was a problem hiding this comment.
@morlov-apexai Okay, but this PR is for the part of the 25.08 release validation week, since the custom toolbar button was changed during the document validation. It is the best to merge this PR in this week. but if you're busy, we can postpone this PR.
There was a problem hiding this comment.
@dongilchang As regards
Do you have any idea?
Yes, this $APPLICATION_CONFIG_DIR$ definition is supposed to be working together with the apex_clion bash script provided with CLion ADE image..
Inside of the apex_clion bash script on start we look for the customization.xml and replacing $APPLICATION_CONFIG_DIR$ with the real local path to the settingsRepository folder.
We were not able to find a good generic solution to make it work out of the box without this custom workaround in apex_clion.
dongilchang
force-pushed
the
13-update-apexai-custom-toolbar-buttons
branch
2 times, most recently
from
cb13cf0 to
c4be4cd
Compare
dongilchang
force-pushed
the
13-update-apexai-custom-toolbar-buttons
branch
from
c4be4cd to
6963f3c
Compare
| <option name="myInitialPosition" value="-1" /> | ||
| </group> | ||
| <group value="Tool_External Tools_Build Current Bazel" is_action="true" action_type="1" position="14"> | ||
| <group value="Tool_External Tools_Generate requirements report" is_action="true" action_type="1" position="13"> |
There was a problem hiding this comment.
It seems this Tools_Generate requirements report as well as others removed icons like Uncrustify shall be removed as well.
What I usually do in this case is clean up panel with builtin CLion panel editor and Settings->Tools->External Tools menu, than saving configs and copy-past my local configs to the git controlled repo.
However, will need to manually replace absolute path to the icons with the "$APPLICATION_CONFIG_DIR$/settingsRepository pattern.
|
@dongilchang Can you please provide a more context about
Why this was needed? |
Please refer to Update Apex.AI custom toolbar buttons #13
Closes Update Apex.AI custom toolbar buttons #13