APERTA-12542 ignore some false positives #4003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@egh when you've got a moment :D |
egh
approved these changes
Mar 3, 2018
Contributor
egh
left a comment
egh
left a comment
There was a problem hiding this comment.
👍 One comment if you want to address it.
| @@ -1,4 +0,0 @@ | |||
| module PlosBilling | |||
| @@ -1,4 +0,0 @@ | |||
| module PlosBioInternalReview | |||
config/brakeman.ignore
Outdated
| }, | ||
| "user_input": null, | ||
| "confidence": "Medium", | ||
| "note": "APERTA-12459" |
Contributor
There was a problem hiding this comment.
No big deal, but maybe link directly to https://github.com/Tahi-project/tahi/pull/2800/files#r94070916 ?
benjaminkreen
force-pushed
the
empowerment/add-to-brakeman-ignore
branch
from
4d53626 to
7543e1f
Compare
Contributor
|
Thanks, @benjaminkreen ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just configuring some things for brakeman to ignore. In the object that is ignored, i've left the associated ticket number in the note.