-
Notifications
You must be signed in to change notification settings - Fork 7
APERTA-12445 first card #3997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
benjaminkreen
merged 3 commits into
master
from
bugs/APERTA-12445-fix-participant-perms
Feb 26, 2018
Merged
APERTA-12445 first card #3997
benjaminkreen
merged 3 commits into
master
from
bugs/APERTA-12445-fix-participant-perms
Feb 26, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca13f61 to
67f1e2e
Compare
67f1e2e to
c9cb594
Compare
c9cb594 to
7e9bddc
Compare
7e9bddc to
8ae9ad5
Compare
8ae9ad5 to
57de9f3
Compare
57de9f3 to
16396e1
Compare
16396e1 to
03103d4
Compare
03103d4 to
60eb083
Compare
60eb083 to
3ae0c0b
Compare
3ae0c0b to
1724f1b
Compare
98387c2 to
879f383
Compare
Contributor
Author
|
Let me know if I should test the toggle permission functionality too |
jhaungs
approved these changes
Feb 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue: https://jira.plos.org/jira/browse/APERTA-12445
What this PR does:
We seem to be lacking the
:view_participantsand:manage_participantpermissions for migrated cards, and in the custom card configurator view. I'm attempting to add those. Here's the chart i've created to use as a key: https://docs.google.com/spreadsheets/d/1TOAN0RITgLLM6f-6zCEu3FM0HdFe5AvCSx2wmYlBY3M/edit?usp=sharingSpecial instructions for Review or PO:
All sorts of fun! Once card config is enabled, you can toggle these settings to your heart's desire. To update existing cards, we're going to need to go into the UI and update them individually, unless there's some more cleverer way to do that.
Major UI changes
TWO NEW COLUMNS!
Code Review Tasks:
Author tasks (delete tasks that don't apply to your PR, this list should be finished before code review):
If I made any UI changes at all, I've let the entire QA team know in the JIRA ticket and in the Aperta QA hipchat room.
I have set the correct component(s) in the JIRA ticket
I have set an appropriate resolution in the JIRA ticket
I have ensured that the Heroku Review App has successfully deployed and is ready for PO UAT.
Reviewer tasks (these should be checked or somehow noted before passing on to PO):