Skip to content

Conversation

@benjaminkreen
Copy link
Contributor

@benjaminkreen benjaminkreen commented Feb 13, 2018

JIRA issue: https://jira.plos.org/jira/browse/APERTA-12445

What this PR does:

We seem to be lacking the :view_participants and :manage_participant permissions for migrated cards, and in the custom card configurator view. I'm attempting to add those. Here's the chart i've created to use as a key: https://docs.google.com/spreadsheets/d/1TOAN0RITgLLM6f-6zCEu3FM0HdFe5AvCSx2wmYlBY3M/edit?usp=sharing

Special instructions for Review or PO:

All sorts of fun! Once card config is enabled, you can toggle these settings to your heart's desire. To update existing cards, we're going to need to go into the UI and update them individually, unless there's some more cleverer way to do that.

Major UI changes

TWO NEW COLUMNS!

Code Review Tasks:

Author tasks (delete tasks that don't apply to your PR, this list should be finished before code review):

  • If I made any UI changes at all, I've let the entire QA team know in the JIRA ticket and in the Aperta QA hipchat room.

  • I have set the correct component(s) in the JIRA ticket

  • I have set an appropriate resolution in the JIRA ticket

  • I have ensured that the Heroku Review App has successfully deployed and is ready for PO UAT.

Reviewer tasks (these should be checked or somehow noted before passing on to PO):

  • I read through the JIRA ticket's AC before doing the rest of the review
  • I ran the code (in the review environment or locally). I agree the running code fulfills the Acceptance Criteria as stated on the JIRA ticket
  • I read the code; it looks good
  • I have found the tests to be sufficient for both positive and negative test cases

@plos-ci-agent plos-ci-agent temporarily deployed to plos-ciagent-pr-3997 February 13, 2018 16:37 Inactive
@benjaminkreen benjaminkreen force-pushed the bugs/APERTA-12445-fix-participant-perms branch from ca13f61 to 67f1e2e Compare February 13, 2018 22:56
@plos-ci-agent plos-ci-agent temporarily deployed to plos-ciagent-pr-3997 February 13, 2018 22:56 Inactive
@benjaminkreen benjaminkreen force-pushed the bugs/APERTA-12445-fix-participant-perms branch from 67f1e2e to c9cb594 Compare February 13, 2018 23:40
@plos-ci-agent plos-ci-agent temporarily deployed to plos-ciagent-pr-3997 February 13, 2018 23:40 Inactive
@benjaminkreen benjaminkreen force-pushed the bugs/APERTA-12445-fix-participant-perms branch from c9cb594 to 7e9bddc Compare February 14, 2018 00:08
@plos-ci-agent plos-ci-agent temporarily deployed to plos-ciagent-pr-3997 February 14, 2018 00:08 Inactive
@benjaminkreen benjaminkreen force-pushed the bugs/APERTA-12445-fix-participant-perms branch from 7e9bddc to 8ae9ad5 Compare February 14, 2018 16:54
@benjaminkreen benjaminkreen force-pushed the bugs/APERTA-12445-fix-participant-perms branch from 8ae9ad5 to 57de9f3 Compare February 14, 2018 16:57
@plos-ci-agent plos-ci-agent temporarily deployed to plos-ciagent-pr-3997 February 14, 2018 16:57 Inactive
@benjaminkreen benjaminkreen force-pushed the bugs/APERTA-12445-fix-participant-perms branch from 57de9f3 to 16396e1 Compare February 14, 2018 18:14
@plos-ci-agent plos-ci-agent temporarily deployed to plos-ciagent-pr-3997 February 14, 2018 18:14 Inactive
@benjaminkreen benjaminkreen force-pushed the bugs/APERTA-12445-fix-participant-perms branch from 16396e1 to 03103d4 Compare February 14, 2018 18:22
@benjaminkreen benjaminkreen force-pushed the bugs/APERTA-12445-fix-participant-perms branch from 03103d4 to 60eb083 Compare February 14, 2018 18:30
@benjaminkreen benjaminkreen force-pushed the bugs/APERTA-12445-fix-participant-perms branch from 60eb083 to 3ae0c0b Compare February 14, 2018 18:33
@benjaminkreen benjaminkreen force-pushed the bugs/APERTA-12445-fix-participant-perms branch from 3ae0c0b to 1724f1b Compare February 14, 2018 18:48
@plos-ci-agent plos-ci-agent temporarily deployed to plos-ciagent-pr-3997 February 14, 2018 18:48 Inactive
@plos-ci-agent plos-ci-agent temporarily deployed to plos-ciagent-pr-3997 February 14, 2018 23:39 Inactive
@benjaminkreen benjaminkreen force-pushed the bugs/APERTA-12445-fix-participant-perms branch from 98387c2 to 879f383 Compare February 14, 2018 23:46
@plos-ci-agent plos-ci-agent temporarily deployed to plos-ciagent-pr-3997 February 14, 2018 23:46 Inactive
@plos-ci-agent plos-ci-agent temporarily deployed to plos-ciagent-pr-3997 February 15, 2018 21:40 Inactive
@benjaminkreen benjaminkreen removed the wip label Feb 15, 2018
@benjaminkreen
Copy link
Contributor Author

Let me know if I should test the toggle permission functionality too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants