generated from ApeWorX/project-template
-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: issue where dependencies used local project's remappings instead of their own #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
changed the title
fix: issue where dependencies-of-dependencies uses remappings of local project instead of their own
fix: issue where dependencies-of-dependencies used remappings of local project instead of their own
Aug 13, 2024
Bonus massive performance gain! Before
After:
|
antazoey
changed the title
fix: issue where dependencies-of-dependencies used remappings of local project instead of their own
fix: issue where dependencies used remappings of local project instead of their own
Aug 14, 2024
antazoey
changed the title
fix: issue where dependencies used remappings of local project instead of their own
fix: issue where dependencies used local project's remappings instead of their own
Aug 14, 2024
antazoey
commented
Aug 15, 2024
# with project defining this dependency, for separate pieces of data. | ||
# (need base project for relative .cache folder location and need dependency | ||
# for configuration). | ||
import_remapping = self.solidity._import_remapping_cache[config_project] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
basically this logic here fixed the bug
bitwise-constructs
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Somehow an unnoticed bug (until recently) where remappings were resolving to paths from the local projects listings rather than looking at config from the dependency's themselves.
How I did it
Refactored all import remap stuff into its own module and relied on pydantic for some of the leg work.
How to verify it
Easy. Make a project with OZ 4.5 and yearn vaults. Ensure yearn vaults imports resolve using OZ 4.7.1 since it is a dependenc of a dependency (different version of OZ). Lemme know if you need help, I can add more info.
Checklist