release 2.4.2

Author: AnyRoad

CHANGELOG.md

@@ -1,3 +1,9 @@
+## 2.4.2
+
+### Bug Fixes
+
+- [beforeExpandChange was not propagated to the child objects](https://github.com/AnyRoad/react-json-view-lite/pull/52)
+
 ## 2.4.1
 
 ### Bug Fixes

package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-json-view-lite",
-  "version": "2.4.1",
+  "version": "2.4.2",
   "description": "JSON viewer component for React focused on performance for large volume input while still providing few customiziation features",
   "homepage": "https://github.com/AnyRoad/react-json-view-lite",
   "author": "AnyRoad",

src/DataRenderer.test.tsx

@@ -568,6 +568,25 @@ describe('DataRender', () => {
     expect(screen.queryByText('123')).not.toBeInTheDocument();
   });
 
+  it('should stop expanding for the nested object if beforeExpandChange returned true', () => {
+    const { container } = render(
+      <WrappedDataRenderer
+        value={{ obj: { test: 123 } }}
+        shouldExpandNode={collapseAllNested}
+        beforeExpandChange={() => false}
+      />
+    );
+    expect(screen.queryByText(/obj/)).toBeInTheDocument();
+    expect(screen.queryByText(/test:/)).not.toBeInTheDocument();
+    expect(screen.queryByText('123')).not.toBeInTheDocument();
+
+    const collapsedContent = container.getElementsByClassName(commonProps.style.collapsedContent);
+    fireEvent.click(collapsedContent[0]);
+    expect(screen.getByText(/obj/)).toBeInTheDocument();
+    expect(screen.queryByText(/test:/)).not.toBeInTheDocument();
+    expect(screen.queryByText('123')).not.toBeInTheDocument();
+  });
+
   it('should stop expanding if beforeExpandChange returned false and render with new shouldExpandNode value', () => {
     let level = null;
     let field = null;

src/stories/JsonView.stories.tsx

@@ -1,15 +1,7 @@
 import React from 'react';
 import { StoryFn, Meta, StoryObj } from '@storybook/react';
-import { useArgs } from '@storybook/preview-api';
 
-import {
-  JsonView,
-  defaultStyles,
-  darkStyles,
-  allExpanded,
-  collapseAllNested,
-  NodeExpandingEvent
-} from '../index';
+import { JsonView, defaultStyles, darkStyles, allExpanded, collapseAllNested } from '../index';
 
 export default {
   title: 'Json View',
@@ -133,35 +125,24 @@ ClickOnFieldNameToExpand.args = {
   clickToExpandNode: true
 };
 
+const tmp = {
+  a: <a href='https://www.google.com'>Google</a>
+};
+
+const JsonViewer: React.FC = () => {
+  return (
+    <div>
+      <JsonView data={tmp} shouldExpandNode={collapseAllNested} />
+    </div>
+  );
+};
+
 type JsonViewStory = StoryObj<typeof JsonView>;
 
 export const ExpandOnlyFirstLevelWhenClickOnRoot: JsonViewStory = {
-  args: {
-    data: jsonData,
-    style: { ...defaultStyles },
-    shouldExpandNode: collapseAll,
-    clickToExpandNode: true
-  },
-  argTypes: {},
-  name: 'Expand only first level on root click (using beforeExpandChange)',
-
-  render: function Render(args) {
-    const [{ shouldExpandNode }, updateArgs] = useArgs();
-
-    const beforeExpandChange = (event: NodeExpandingEvent) => {
-      if (event.level === 0 && event.newExpandValue) {
-        updateArgs({ shouldExpandNode: (level: number) => level < 1 });
-        return false;
-      }
-      return true;
-    };
-
-    return (
-      <JsonView
-        {...args}
-        beforeExpandChange={beforeExpandChange}
-        shouldExpandNode={shouldExpandNode}
-      />
-    );
+  name: 'Bug test',
+
+  render: function Render() {
+    return <JsonViewer />;
   }
 };

yarn.lock

@@ -4120,9 +4120,9 @@ __metadata:
   linkType: hard
 
 "caniuse-lite@npm:^1.0.0, caniuse-lite@npm:^1.0.30001109, caniuse-lite@npm:^1.0.30001688":
-  version: 1.0.30001702
-  resolution: "caniuse-lite@npm:1.0.30001702"
-  checksum: ba8e88f0ef09a16f36de805c9491c3047986ab6bb1e0dc66f03067dce5e197be1c98cfaed21867bad851985f775b8d4fa50e7e37537c116a5fe1ae623dfd400c
+  version: 1.0.30001731
+  resolution: "caniuse-lite@npm:1.0.30001731"
+  checksum: ecd2ad779f31011bef657c0104a08a780d9bb38ff8ad7aeeeaf196151be22c492de87f4a9c89a30ea4aa9575c5a39c85bf6bd56e89a4bf8259f54a4fbfc24a0d
   languageName: node
   linkType: hard