fixup! refactor: xml namespaces are stoored ein php constants

kouinkouin · kouinkouin · commit 175dd5be6cda · 2024-10-14T01:35:42.000+02:00
diff --git a/src/Bpost/Order/Box/Option/Insured.php b/src/Bpost/Order/Box/Option/Insured.php
@@ -138,7 +138,6 @@ public function __construct($type, $value = null)
      * Return the object as an array for usage in the XML
      *
      * @param DomDocument $document
-     * @param string      $prefix
      *
      * @return DomElement
      *
@@ -167,7 +166,7 @@ public function toXML(DOMDocument $document, $prefix = 'common')
      */
     public static function createFromXML(SimpleXMLElement $xml)
     {
-        $insuranceDetail = $xml->children(Bpost::NS_V3_COMMON);
+        $insuranceDetail = $xml->children('common', true);
 
         $type = $insuranceDetail->getName();
         $value = $insuranceDetail->attributes()->value !== null ? (int) $insuranceDetail->attributes()->value : null;

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,6 @@ public function __construct($type, $value = null)`
`138`	`138`	`* Return the object as an array for usage in the XML`
`139`	`139`	`*`
`140`	`140`	`* @param DomDocument $document`
`141`		`- * @param string $prefix`
`142`	`141`	`*`
`143`	`142`	`* @return DomElement`
`144`	`143`	`*`
`@@ -167,7 +166,7 @@ public function toXML(DOMDocument $document, $prefix = 'common')`
`167`	`166`	`*/`
`168`	`167`	`public static function createFromXML(SimpleXMLElement $xml)`
`169`	`168`	`{`
`170`		`- $insuranceDetail = $xml->children(Bpost::NS_V3_COMMON);`
	`169`	`+ $insuranceDetail = $xml->children('common', true);`
`171`	`170`
`172`	`171`	`$type = $insuranceDetail->getName();`
`173`	`172`	`$value = $insuranceDetail->attributes()->value !== null ? (int) $insuranceDetail->attributes()->value : null;`