feat: align rules with "bpack integration manual" v3.3.30 (section B.2.2.1) #8

Author: kouinkouin

src/FormHandler.php

@@ -129,15 +129,16 @@ public function setParameter($key, $value)
                 $this->parameters[$key] = $value;
                 break;
 
-                // maximum 2 chars
+            // maximum 2 chars
             case 'customerCountry':
                 if (mb_strlen($value) > 2) {
                     throw new BpostInvalidLengthException($key, mb_strlen($value), 2);
                 }
                 $this->parameters[$key] = (string) $value;
                 break;
 
-                // maximum 8 chars
+            // maximum 8 chars
+            case 'customerPostalCode':
             case 'customerStreetNumber':
             case 'customerBox':
                 if (mb_strlen($value) > 8) {
@@ -146,35 +147,42 @@ public function setParameter($key, $value)
                 $this->parameters[$key] = (string) $value;
                 break;
 
-                // maximum 20 chars
+            // maximum 20 chars
             case 'customerPhoneNumber':
                 if (mb_strlen($value) > 20) {
                     throw new BpostInvalidLengthException($key, mb_strlen($value), 20);
                 }
                 $this->parameters[$key] = (string) $value;
                 break;
 
-                // maximum 32 chars
-            case 'customerPostalCode':
-                if (mb_strlen($value) > 32) {
-                    throw new BpostInvalidLengthException($key, mb_strlen($value), 32);
+            // maximum 40 chars
+            case 'customerCompany':
+            case 'customerStreet':
+            case 'customerCity':
+                if (mb_strlen($value) > 40) {
+                    throw new BpostInvalidLengthException($key, mb_strlen($value), 40);
                 }
                 $this->parameters[$key] = (string) $value;
                 break;
 
-                // maximum 40 chars
+            // sum = maximum 40 chars
             case 'customerFirstName':
             case 'customerLastName':
-            case 'customerCompany':
-            case 'customerStreet':
-            case 'customerCity':
-                if (mb_strlen($value) > 40) {
-                    throw new BpostInvalidLengthException($key, mb_strlen($value), 40);
+                $names = array(
+                    'customerFirstName' => $this->parameters['customerFirstName'] ?: '',
+                    'customerLastName' => $this->parameters['customerLastName'] ?: '',
+                );
+                $names[$key] = $value;
+                $sum = array_sum(array_map(function ($item) {
+                    return mb_strlen($item);
+                }, $names));
+                if ($sum > 40) {
+                    throw new BpostInvalidLengthException($key, $sum, 40);
                 }
                 $this->parameters[$key] = (string) $value;
                 break;
 
-                // maximum 50 chars
+            // maximum 50 chars
             case 'orderReference':
             case 'costCenter':
             case 'customerEmail':
@@ -184,21 +192,21 @@ public function setParameter($key, $value)
                 $this->parameters[$key] = (string) $value;
                 break;
 
-                // integers
+            // integers
             case 'orderTotalPrice':
             case 'orderWeight':
                 $this->parameters[$key] = (int) $value;
                 break;
 
-                // array
+            // array
             case 'orderLine':
                 if (!isset($this->parameters[$key])) {
                     $this->parameters[$key] = array();
                 }
                 $this->parameters[$key][] = $value;
                 break;
 
-                // unknown
+            // unknown
             case 'deliveryMethodOverrides':
             case 'extra':
             case 'extraSecure':