Open
Conversation
…y. Transactions now execute when there are no other queued tasks to execute in the read-write or read-only queues. As of this commit, all trxs have the same priority, but that will change in the future.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…se are logged when switching to read window.
…me additional comments.
…complex, not simplier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Wire-Network/wire-sysio#163
Add a separate trx execution queue,
trx_read_write, that is executed from when there are noread_writeorread_onlytasks to execute. This preserves running trxs as the lowest priority task, but allows for individual prioritization of transactions. As of this PR, all transactions have the same priority, however, this adds the framework for specifying different priorities for transactions. The newtrx_read_writequeue is only for non-read-only transactions. Read-only transactions are still executed in FIFO order on multiple threads.In addition to allowing for different priorities for transactions, this change also reduces the contention on the main
io_contextwhich in previous benchmarking was demonstrated to be a bottleneck for small transfer like transactions.See AntelopeIO/leap#1860