Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: don't print on import, or make printing configurable #36

Open
lsorber opened this issue Oct 6, 2024 · 1 comment
Open

Comments

@lsorber
Copy link

lsorber commented Oct 6, 2024

This print statement runs on import, with no option to configure or disable it:

>>> import rerankers
Torch not installed...

May I kindly request to not print on import, or to make printing configurable? Thank you! In general, it's good practice to limit code that runs on import to a minimum.

Source:

print("Torch not installed...")

@lsorber
Copy link
Author

lsorber commented Oct 6, 2024

Same thing for the print statements in:

print(f"Loading {model_type} model {model_name}")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant