Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nb_hdrs to fast_app #551

Merged
merged 2 commits into from
Oct 27, 2024
Merged

Conversation

Isaac-Flath
Copy link
Contributor


name: nb_hdrs in fast_app
about: nb_hdrs arg from FastHTML missing from `fast_app
title: '[PR] '
labels: ''
assignees: ''


Proposed Changes
The FastHTML class has nb_hdrs argument which allows you to opt out of headers being injecting into notebook dom. This PR adds that to fast_app as well so the option exists there as well.

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist
Go over all the following points, and put an x in all the boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

@Isaac-Flath Isaac-Flath added the bug Something isn't working label Oct 27, 2024
@Isaac-Flath Isaac-Flath requested a review from jph00 October 27, 2024 02:49
@jph00 jph00 merged commit a54e0d3 into AnswerDotAI:main Oct 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants