Fix site errors

Author: bitwiseman

.github/workflows/maven-build.yml

@@ -19,4 +19,4 @@ jobs:
     - name: Maven Download all dependencies
       run: mvn -B org.apache.maven.plugins:maven-dependency-plugin:3.1.1:go-offline
     - name: Maven Build
-      run: mvn -B package --file pom.xml
+      run: mvn -B install site --file pom.xml

pom.xml

@@ -60,9 +60,45 @@
           <artifactId>jacoco-maven-plugin</artifactId>
           <version>0.8.5</version>
         </plugin>
+        <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
+          <artifactId>maven-javadoc-plugin</artifactId>
+          <version>3.1.1</version>
+        </plugin>
       </plugins>
     </pluginManagement>
     <plugins>
+
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-site-plugin</artifactId>
+        <version>3.8.2</version>
+      </plugin>
+      <plugin>
+        <artifactId>maven-release-plugin</artifactId>
+        <version>2.5.3</version>
+        <configuration>
+          <releaseProfiles>release</releaseProfiles>
+        </configuration>
+      </plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-project-info-reports-plugin</artifactId>
+        <version>3.0.0</version>
+        <dependencies>
+          <dependency>
+            <groupId>org.apache.bcel</groupId>
+            <artifactId>bcel</artifactId>
+            <version>6.4.1</version>
+          </dependency>
+        </dependencies>
+      </plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-source-plugin</artifactId>
+        <version>3.1.0</version>
+      </plugin>
+
       <plugin>
         <artifactId>maven-compiler-plugin</artifactId>
         <version>3.8.1</version>
@@ -217,7 +253,7 @@
     <dependency>
       <groupId>org.eclipse.jgit</groupId>
       <artifactId>org.eclipse.jgit</artifactId>
-      <version>5.5.1.201910021850-r</version>
+      <version>5.4.3.201909031940-r</version>
       <scope>test</scope>
     </dependency>
     <dependency>
@@ -292,7 +328,7 @@
       <id>jacoco</id>
       <activation>
         <property>
-          <name>!jacoco.disabled</name>
+          <name>enable-jacoco</name>
         </property>
       </activation>
       <build>
@@ -392,6 +428,10 @@
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-javadoc-plugin</artifactId>
       </plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-project-info-reports-plugin</artifactId>
+      </plugin>
     </plugins>
   </reporting>
 

src/main/java/org/kohsuke/github/AbuseLimitHandler.java

@@ -27,6 +27,7 @@ public abstract class AbuseLimitHandler {
      *      this exception (or wrap this exception into another exception and throw it).
      * @param uc
      *      Connection that resulted in an error. Useful for accessing other response headers.
+     * @throws IOException
      */
     public abstract void onError(IOException e, HttpURLConnection uc) throws IOException;
 
@@ -38,7 +39,7 @@ public abstract class AbuseLimitHandler {
         public void onError(IOException e, HttpURLConnection uc) throws IOException {
             try {
                 Thread.sleep(parseWaitTime(uc));
-            } catch (InterruptedException _) {
+            } catch (InterruptedException ex) {
                 throw (InterruptedIOException)new InterruptedIOException().initCause(e);
             }
         }

src/main/java/org/kohsuke/github/GHApp.java

@@ -104,6 +104,7 @@ public void setPermissions(Map<String, String> permissions) {
      * You must use a JWT to access this endpoint.
      *
      * @see <a href="https://developer.github.com/v3/apps/#list-installations">List installations</a>
+     * @return a list of App installations
      */
     @Preview @Deprecated
     public PagedIterable<GHAppInstallation> listInstallations() {

src/main/java/org/kohsuke/github/GHProject.java

@@ -32,7 +32,7 @@
 
 /**
  * A GitHub project.
- * @see https://developer.github.com/v3/projects/
+ * @see <a href="https://developer.github.com/v3/projects/">Projects</a>
  * @author Martin van Zijl
  */
 public class GHProject extends GHObject {

src/main/java/org/kohsuke/github/GitHub.java

@@ -551,7 +551,7 @@ public Map<String, GHOrganization> getUserPublicOrganizations(GHUser user) throw
      *
      * To retrieve full organization details, you need to call {@link #getOrganization(String)}
      *
-     * @param user the user to retrieve public Organization membership information for
+     * @param login the user to retrieve public Organization membership information for
      *
      * @return the public Organization memberships for the user
      */