Skip to content

Commit 6231d6d

Browse files
committed
Work around netifaces Windows netmask bug
1 parent 48b1949 commit 6231d6d

File tree

3 files changed

+14
-2
lines changed

3 files changed

+14
-2
lines changed

README.rst

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,13 @@ See examples directory for more.
122122
Changelog
123123
=========
124124

125+
0.19.0
126+
------
127+
128+
* Technically backwards incompatible - restricted netifaces dependency version to
129+
work around a bug, see https://github.com/jstasiak/python-zeroconf/issues/84 for
130+
details
131+
125132
0.18.0 (not released yet)
126133
-------------------------
127134

requirements-dev.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ flake8-blind-except
88
# Upper bound because of https://github.com/public/flake8-import-order/issues/42
99
flake8-import-order>=0.4.0, <0.6.0
1010
mock
11-
netifaces
11+
# See setup.py comment for why this version is restricted
12+
netifaces<=0.10.4
1213
nose
1314
pep8==1.5.7
1415
pep8-naming

setup.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,11 @@
5656
],
5757
install_requires=[
5858
'enum-compat',
59-
'netifaces',
59+
# netifaces 0.10.5 has a bug that results in all interfaces' netmasks
60+
# to be 255.255.255.255 on Windows which breaks things. See:
61+
# * https://github.com/jstasiak/python-zeroconf/issues/84
62+
# * https://bitbucket.org/al45tair/netifaces/issues/39/netmask-is-always-255255255255
63+
'netifaces<=0.10.4',
6064
'six',
6165
],
6266
)

0 commit comments

Comments
 (0)