Skip to content

Conversation

@AndrewAnnex
Copy link
Owner

@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 82.69231% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.71%. Comparing base (6858ed5) to head (1447974).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/spiceypy/utils/libspicehelper.py 25.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
- Coverage   99.75%   99.71%   -0.04%     
==========================================
  Files          16       17       +1     
  Lines       17780    17829      +49     
==========================================
+ Hits        17737    17779      +42     
- Misses         43       50       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@acpaquette acpaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! As long as it handles the case metioned in the issue, I think we should be good.

A couple questions around the implementation

@AndrewAnnex
Copy link
Owner Author

@acpaquette while I think this pr will address your issue, but I don't have any visibility into the ISIS tests/how where you use loguru so really you should report back if these changes fix things on your end (you can edit the file in the site_packages folder for spiceypy to verify). I will probably merge this though anyways, but I will wait until around new years to cut a bug fix release (due to travel I have).

@AndrewAnnex AndrewAnnex merged commit 687ec02 into main Dec 19, 2025
38 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spicepy Logger Issues

3 participants