Skip to content
This repository was archived by the owner on Feb 18, 2025. It is now read-only.

Commit d904fd6

Browse files
committed
Do not destroy target item until after item prototype has been processed.
1 parent 5f1aad4 commit d904fd6

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/RecycledItems.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,6 @@ bool RecycledItemsPlayerScript::CanCastItemUseSpell(Player* player, Item* item,
318318
RecycleItem(targetItem, player);
319319

320320
player->DestroyItemCount(itemProto->ItemId, 1, true); // Remote Recycler Item
321-
player->DestroyItem(targetItem->GetBagSlot(), targetItem->GetSlot(), true);
322321

323322
auto targetItemProto = targetItem->GetTemplate();
324323

@@ -327,6 +326,8 @@ bool RecycledItemsPlayerScript::CanCastItemUseSpell(Player* player, Item* item,
327326
uint32 money = sellPrice * bonusMultiplier;
328327
player->ModifyMoney(money);
329328

329+
player->DestroyItem(targetItem->GetBagSlot(), targetItem->GetSlot(), true);
330+
330331
std::string msg = Acore::StringFormatFmt("|cffFFFFFFGained {} |cffFFFFFFfor recycling.|r", GetCurrencyStringFromCopper(money));
331332
WorldPacket notifyPacket(SMSG_NOTIFICATION, msg.size() + 1);
332333
notifyPacket << msg;

0 commit comments

Comments
 (0)