Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Rust-native code to transcode audio in the audio pipeline #38

Closed
philpax opened this issue Feb 10, 2023 · 1 comment · Fixed by #317
Closed

Use Rust-native code to transcode audio in the audio pipeline #38

philpax opened this issue Feb 10, 2023 · 1 comment · Fixed by #317
Assignees
@chaosprint @marceline-cramer
Labels
enhancement New feature or request meta:good first issue Good for newcomers topic:assets Asset loading, streaming, etc

Comments

@philpax
Copy link
Contributor

philpax commented Feb 10, 2023

At present, we shell out to ffmpeg to transcode audio to ogg. To reduce the dependency on external utilities (especially on Windows), we should consider using the symphonia crate to decode all supported audio formats, and then encode it with one of the ogg encoding crates.
@philpax philpax added enhancement New feature or request meta:good first issue Good for newcomers topic:assets Asset loading, streaming, etc labels Feb 10, 2023
@chaosprint chaosprint self-assigned this Apr 12, 2023
@marceline-cramer
Copy link
Contributor

Hey, I want to let everyone know that I've already started working on this and will have a PR for it soon.

@marceline-cramer marceline-cramer mentioned this issue Apr 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chaosprint chaosprint

@marceline-cramer marceline-cramer

Labels
enhancement New feature or request meta:good first issue Good for newcomers topic:assets Asset loading, streaming, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rust-native audio transcoding marceline-cramer/Ambient
3 participants
@philpax @chaosprint @marceline-cramer