Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a HTTP error(instead of 200) when the show_replica_status REST API call fails. #657

Closed
subkanthi opened this issue Jun 24, 2024 · 1 comment
Assignees
Labels
dev-complete Development completed lightweight Issues related to Lightweight version qa-verified label to mark issues that were verified by QA
Milestone

Comments

@subkanthi
Copy link
Collaborator

subkanthi commented Jun 24, 2024

Currently if there is an error in the show_replica_status call, 200 error is returned.
Instead of 200, if there is an error, an error code needs to be returned along with the cause of the error.

@subkanthi subkanthi self-assigned this Jun 24, 2024
@subkanthi subkanthi added this to the 2.2.0 milestone Jun 24, 2024
@subkanthi subkanthi added dev-complete Development completed lightweight Issues related to Lightweight version labels Jun 24, 2024
@subkanthi
Copy link
Collaborator Author

./sink-connector-client show_replica_status
{
  "error": "java.sql.BatchUpdateException: Code: 60. DB::Exception: Unknown table expression identifier 'replica_source_info' in scope SELECT * FROM replica_source_info LIMIT 1. (UNKNOWN_TABLE) (version 24.5.3.5 (official build))\n, server ClickHouseNode [uri=http:\/\/localhost:8123\/system, options={custom_settings=allow_experimental_object_type=1,insert_allow_materialized_columns=1,client_name=Client_1}]@177934022"
}

@Selfeer Selfeer added the qa-verified label to mark issues that were verified by QA label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-complete Development completed lightweight Issues related to Lightweight version qa-verified label to mark issues that were verified by QA
Projects
None yet
Development

No branches or pull requests

2 participants