Set up to 10 custom headers on go client #613
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Slach I see you active, I wonder if you might be able to take a look at this? |
|
sorry for late response, failures in e2e test is not related to your PR, to ensure could you merge latest comits from master something like |
addshore
force-pushed
the
pkg-client_custom-headers
branch
from
688d7aa
to
b3c7c5f
Compare
|
@Slach it looks like CI is all good now! |
|
yep, but actually it conflicts with #594 and i don't like implementation about 10 headers |
|
Aaah, is #594 removing this |
|
sorry we don't provide any ETA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #483
I was not able to test this in a development environemtn myself, however the code change si rather straight forward.
Open to ideas to better read the JSON, but ultimately I believe this should work for 99.9% of folks cases and isn;t too ugly.
We could always up the limit from 10 with little effort.
I'd be happy to have #483 resolved!