Skip to content

Fix rendezvous hashing in complex queries #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2025

Conversation

ianton-ru
Copy link

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Rendevous hashing was not work properly in complex queries

Documentation entry for user-facing changes

Rendevous hashing was not work properly in complex queries like

insert into test_insert select * from s3Cluster('cluster', 'http://minio1:9001/root/data/hivebig/key=**', 'minio', 'minio123', 'CSVWithNames') SETTINGS parallel_distributed_insert_select=1

@ianton-ru ianton-ru marked this pull request as ready for review May 2, 2025 10:55
@arthurpassos
Copy link
Collaborator

Can you please provide more context? Why it wasn't working, the root problem and how it was fixed?

@ianton-ru
Copy link
Author

Can you please provide more context? Why it wasn't working, the root problem and how it was fixed?

ids_of_nodes does not fill in some cases, it was optional and nullopt was used. Than connection_to_files got size 1, and requests failed with exception No list of nodes inside Task Distributer.. Or worse, with number_of_current_replica >= 1 array connection_to_files used out of bound with possible segfault.

Now ids_of_nodes filled always. Initializing moved inside getTaskIteratorExtension.

Copy link
Member

@Enmk Enmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Enmk Enmk merged commit ab9d58f into antalya May 3, 2025
259 of 322 checks passed
ianton-ru pushed a commit that referenced this pull request May 23, 2025
Enmk added a commit that referenced this pull request May 29, 2025
…_hashing

25.3 Antalya port of #709, #760 - Rendezvous hashing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants