24.8 Use credentials from secrets #693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MyroTk
changed the title
Enmk
reviewed
Mar 25, 2025
docker/packager/packager
Outdated
|
|
||
| SCRIPT_PATH = Path(__file__).absolute() | ||
| IMAGE_TYPE = "binary-builder" | ||
| IMAGE_NAME = f"altinityinfra/{IMAGE_TYPE}" | ||
|
|
||
| TEMP_PATH = os.getenv("TEMP_PATH", p.abspath(p.join(module_dir, "./tmp"))) |
There was a problem hiding this comment.
Maybe just:
Suggested change
| TEMP_PATH = os.getenv("TEMP_PATH", p.abspath(p.join(module_dir, "./tmp"))) | |
| DEFAULT_TMP_PATH = SCRIPT_PATH.parent.absolute() / 'tmp' | |
| TEMP_PATH = Path(os.getenv("TEMP_PATH", DEFAULT_TMP_PATH)) |
?
Enmk
reviewed
Mar 25, 2025
Comment on lines
+60
to
+64
| CLICKHOUSE_TEST_STAT_LOGIN: ${{ secrets.CLICKHOUSE_TEST_STAT_LOGIN }} | ||
| CLICKHOUSE_TEST_STAT_PASSWORD: ${{ secrets.CLICKHOUSE_TEST_STAT_PASSWORD }} | ||
| CLICKHOUSE_TEST_STAT_URL: ${{ secrets.CLICKHOUSE_TEST_STAT_URL }} | ||
| DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }} | ||
| ROBOT_TOKEN: ${{ secrets.ROBOT_TOKEN }} |
There was a problem hiding this comment.
It looks like we need to add those to the section above for this worklow to work properly on workflow_call
Enmk
reviewed
Mar 25, 2025
| global ROBOT_TOKEN | ||
| if ROBOT_TOKEN is not None: | ||
| return ROBOT_TOKEN | ||
| ROBOT_TOKEN = get_parameter_from_ssm(token_prefix_env_name) | ||
| return ROBOT_TOKEN |
There was a problem hiding this comment.
It looks like ROBOT_TOKEN is always going to be None, due assignment above:
ROBOT_TOKEN = None # type: Optional[Token]
11 tasks
|
This is an automated comment for commit 926c396 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
Enmk
added a commit
that referenced
this pull request
Mar 26, 2025
…ecrets 24.8 Use credentials from secrets
Enmk
added a commit
that referenced
this pull request
Mar 26, 2025
…crets Antalya backport of #693 - Use credentials from secrets
zvonand
pushed a commit
that referenced
this pull request
May 5, 2025
…ecrets 24.8 Use credentials from secrets
zvonand
pushed a commit
that referenced
this pull request
May 5, 2025
…ecrets 24.8 Use credentials from secrets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):